From: Alistair Francis <alistair.francis@xilinx.com>
To: qemu-devel@nongnu.org
Cc: alistair.francis@xilinx.com, alistair23@gmail.com,
philippe@mathieu-daude.net, berrange@redhat.com,
armbru@redhat.com
Subject: [Qemu-devel] [PATCH v1 0/6] Implement a warning_report function
Date: Thu, 6 Jul 2017 16:49:03 -0700 [thread overview]
Message-ID: <cover.1499381754.git.alistair.francis@xilinx.com> (raw)
QEMU currently has a standard method to report errors with
error_repot(). This ensure a sane and standard format when printing
errors. This series is attempting to extend this functionality for
warnings and information as well.
This patch renames error_print_loc() function to be more clear, but I
didn't bother renaming the others. It seems silly to change
error_printf() to error_warning_printf() and printf is already taken so
I just left it as is.
v1:
- Convert all of the existing warning messages in QEMU
- Add a error_report*_err() functions as well
RFCv3:
- Use more detailed enum and function names
- Add wrapper functions for the info and warning reporting
RFCv2:
- Use enums for ERROR, WARN and INFO with a generic report() function
instead of adding new functions
Alistair Francis (6):
util/qemu-error: Rename error_print_loc() to be more generic
error: Functions to report warnings and informational messages
Convert error_report() to warn_report()
char-socket: Report TCP socket waiting as information
error: Implement the warn and free Error functions
Convert error_report*_err() to warn_report*_err()
block/backup.c | 10 +++---
block/gluster.c | 2 +-
block/iscsi.c | 2 +-
block/nfs.c | 12 +++----
block/rbd.c | 6 ++--
block/ssh.c | 4 +--
blockdev.c | 2 +-
chardev/char-socket.c | 4 +--
cpus.c | 2 +-
hw/9pfs/9p.c | 2 +-
hw/arm/highbank.c | 6 ++--
hw/arm/imx25_pdk.c | 6 ++--
hw/arm/kzm.c | 6 ++--
hw/core/machine.c | 10 +++---
hw/core/qdev-properties.c | 10 +++---
hw/i386/acpi-build.c | 10 +++---
hw/i386/kvm/pci-assign.c | 6 ++--
hw/i386/pc.c | 15 ++++----
hw/i386/pc_piix.c | 8 ++---
hw/i386/pc_q35.c | 6 ++--
hw/misc/aspeed_sdmc.c | 8 ++---
hw/nvram/fw_cfg.c | 2 +-
hw/pci-host/piix.c | 2 +-
hw/ppc/pnv.c | 6 ++--
hw/ppc/spapr.c | 4 +--
hw/ppc/spapr_iommu.c | 2 +-
hw/scsi/scsi-bus.c | 6 ++--
hw/usb/dev-smartcard-reader.c | 6 ++--
hw/usb/redirect.c | 2 +-
include/qapi/error.h | 11 ++++++
include/qemu/error-report.h | 7 ++++
net/tap-linux.c | 2 +-
scripts/checkpatch.pl | 8 ++++-
target/i386/cpu.c | 22 ++++++------
target/i386/kvm.c | 10 +++---
target/s390x/cpu_models.c | 6 ++--
target/s390x/kvm.c | 4 +--
tests/test-qdev-global-props.c | 6 ++--
trace/control.c | 8 ++---
util/error.c | 19 ++++++++++
util/qemu-error.c | 82 +++++++++++++++++++++++++++++++++++++-----
vl.c | 20 +++++------
42 files changed, 239 insertions(+), 133 deletions(-)
--
2.11.0
next reply other threads:[~2017-07-06 23:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-06 23:49 Alistair Francis [this message]
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 1/6] util/qemu-error: Rename error_print_loc() to be more generic Alistair Francis
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 2/6] error: Functions to report warnings and informational messages Alistair Francis
2017-07-07 12:59 ` Markus Armbruster
2017-07-07 17:10 ` Alistair Francis
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 3/6] Convert error_report() to warn_report() Alistair Francis
2017-07-07 0:14 ` Peter.Chubb
2017-07-07 17:19 ` Alistair Francis
2017-07-10 8:06 ` Markus Armbruster
2017-07-10 12:02 ` Philippe Mathieu-Daudé
2017-07-07 1:09 ` David Gibson
2017-07-07 6:33 ` Thomas Huth
2017-07-07 11:58 ` Eduardo Habkost
2017-07-07 12:07 ` Thomas Huth
2017-07-07 6:33 ` Greg Kurz
2017-07-07 8:29 ` Cornelia Huck
2017-07-07 12:06 ` Eduardo Habkost
2017-07-07 17:39 ` Alistair Francis
2017-07-07 12:32 ` Stefan Hajnoczi
2017-07-07 12:48 ` Markus Armbruster
2017-07-07 17:30 ` Alistair Francis
2017-07-10 7:49 ` Marcel Apfelbaum
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 4/6] char-socket: Report TCP socket waiting as information Alistair Francis
2017-07-07 11:32 ` Philippe Mathieu-Daudé
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 5/6] error: Implement the warn and free Error functions Alistair Francis
2017-07-06 23:49 ` [Qemu-devel] [PATCH v1 6/6] Convert error_report*_err() to warn_report*_err() Alistair Francis
2017-07-07 11:41 ` Philippe Mathieu-Daudé
2017-07-07 12:07 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1499381754.git.alistair.francis@xilinx.com \
--to=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=philippe@mathieu-daude.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).