* [Qemu-devel] [PATCH 0/1] Buffers/caches in VirtIO Balloon driver stats @ 2017-09-20 16:05 Tomáš Golembiovský 2017-09-20 16:05 ` [Qemu-devel] [PATCH 1/1] virtio-balloon: include buffers and chached memory statistics Tomáš Golembiovský 0 siblings, 1 reply; 4+ messages in thread From: Tomáš Golembiovský @ 2017-09-20 16:05 UTC (permalink / raw) To: virtio-dev, qemu-devel Cc: Wei Wang, Michael S. Tsirkin, Tomáš Golembiovský This is a QEMU counterpart to the patch for VirtIO balloon driver posted here: https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg05720.html Tomáš Golembiovský (1): virtio-balloon: include buffers and chached memory statistics hw/virtio/virtio-balloon.c | 2 ++ include/standard-headers/linux/virtio_balloon.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) -- 2.14.1 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [Qemu-devel] [PATCH 1/1] virtio-balloon: include buffers and chached memory statistics 2017-09-20 16:05 [Qemu-devel] [PATCH 0/1] Buffers/caches in VirtIO Balloon driver stats Tomáš Golembiovský @ 2017-09-20 16:05 ` Tomáš Golembiovský 2017-11-16 13:38 ` [Qemu-devel] [virtio-dev] " Yan Vugenfirer 0 siblings, 1 reply; 4+ messages in thread From: Tomáš Golembiovský @ 2017-09-20 16:05 UTC (permalink / raw) To: virtio-dev, qemu-devel Cc: Wei Wang, Michael S. Tsirkin, Tomáš Golembiovský Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> --- hw/virtio/virtio-balloon.c | 2 ++ include/standard-headers/linux/virtio_balloon.h | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c index a705e0ec55..0434784c14 100644 --- a/hw/virtio/virtio-balloon.c +++ b/hw/virtio/virtio-balloon.c @@ -49,6 +49,8 @@ static const char *balloon_stat_names[] = { [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory", [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory", [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory", + [VIRTIO_BALLOON_S_BUFFERS] = "stat-linux-buffers", + [VIRTIO_BALLOON_S_CACHED] = "stat-linux-cached", [VIRTIO_BALLOON_S_NR] = NULL }; diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h index 9d06ccd066..d61efbfcee 100644 --- a/include/standard-headers/linux/virtio_balloon.h +++ b/include/standard-headers/linux/virtio_balloon.h @@ -52,7 +52,9 @@ struct virtio_balloon_config { #define VIRTIO_BALLOON_S_MEMFREE 4 /* Total amount of free memory */ #define VIRTIO_BALLOON_S_MEMTOT 5 /* Total amount of memory */ #define VIRTIO_BALLOON_S_AVAIL 6 /* Available memory as in /proc */ -#define VIRTIO_BALLOON_S_NR 7 +#define VIRTIO_BALLOON_S_BUFFERS 7 /* Buffers memory as in /proc */ +#define VIRTIO_BALLOON_S_CACHED 8 /* Cached memory as in /proc */ +#define VIRTIO_BALLOON_S_NR 9 /* * Memory statistics structure. -- 2.14.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [virtio-dev] [PATCH 1/1] virtio-balloon: include buffers and chached memory statistics 2017-09-20 16:05 ` [Qemu-devel] [PATCH 1/1] virtio-balloon: include buffers and chached memory statistics Tomáš Golembiovský @ 2017-11-16 13:38 ` Yan Vugenfirer 2017-11-16 14:07 ` Tomáš Golembiovský 0 siblings, 1 reply; 4+ messages in thread From: Yan Vugenfirer @ 2017-11-16 13:38 UTC (permalink / raw) To: Tomáš Golembiovský Cc: virtio-dev, qemu-devel, Wei Wang, Michael S. Tsirkin Hello All, Michael asked me to comment regarding the possibility to get this statistics on Windows. By using Win32_OperatingSystem WMI class we can calculate the amount of cached memory (https://msdn.microsoft.com/en-us/library/aa394239(v=vs.85).aspx <https://msdn.microsoft.com/en-us/library/aa394239(v=vs.85).aspx> http://brandonlive.com/2010/02/21/measuring-memory-usage-in-windows-7/ <http://brandonlive.com/2010/02/21/measuring-memory-usage-in-windows-7/>), but Windows doesn’t let to distinguish between “cached and buffers” as far as I see. Best regards, Yan. > On 20 Sep 2017, at 19:05, Tomáš Golembiovský <tgolembi@redhat.com> wrote: > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > --- > hw/virtio/virtio-balloon.c | 2 ++ > include/standard-headers/linux/virtio_balloon.h | 4 +++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > index a705e0ec55..0434784c14 100644 > --- a/hw/virtio/virtio-balloon.c > +++ b/hw/virtio/virtio-balloon.c > @@ -49,6 +49,8 @@ static const char *balloon_stat_names[] = { > [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory", > [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory", > [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory", > + [VIRTIO_BALLOON_S_BUFFERS] = "stat-linux-buffers", > + [VIRTIO_BALLOON_S_CACHED] = "stat-linux-cached", > [VIRTIO_BALLOON_S_NR] = NULL > }; > > diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h > index 9d06ccd066..d61efbfcee 100644 > --- a/include/standard-headers/linux/virtio_balloon.h > +++ b/include/standard-headers/linux/virtio_balloon.h > @@ -52,7 +52,9 @@ struct virtio_balloon_config { > #define VIRTIO_BALLOON_S_MEMFREE 4 /* Total amount of free memory */ > #define VIRTIO_BALLOON_S_MEMTOT 5 /* Total amount of memory */ > #define VIRTIO_BALLOON_S_AVAIL 6 /* Available memory as in /proc */ > -#define VIRTIO_BALLOON_S_NR 7 > +#define VIRTIO_BALLOON_S_BUFFERS 7 /* Buffers memory as in /proc */ > +#define VIRTIO_BALLOON_S_CACHED 8 /* Cached memory as in /proc */ > +#define VIRTIO_BALLOON_S_NR 9 > > /* > * Memory statistics structure. > -- > 2.14.1 > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [virtio-dev] [PATCH 1/1] virtio-balloon: include buffers and chached memory statistics 2017-11-16 13:38 ` [Qemu-devel] [virtio-dev] " Yan Vugenfirer @ 2017-11-16 14:07 ` Tomáš Golembiovský 0 siblings, 0 replies; 4+ messages in thread From: Tomáš Golembiovský @ 2017-11-16 14:07 UTC (permalink / raw) To: Yan Vugenfirer; +Cc: virtio-dev, qemu-devel, Wei Wang, Michael S. Tsirkin On Thu, 16 Nov 2017 15:38:21 +0200 Yan Vugenfirer <yvugenfi@redhat.com> wrote: > Hello All, > > Michael asked me to comment regarding the possibility to get this statistics on Windows. > By using Win32_OperatingSystem WMI class we can calculate the amount of cached memory (https://msdn.microsoft.com/en-us/library/aa394239(v=vs.85).aspx <https://msdn.microsoft.com/en-us/library/aa394239(v=vs.85).aspx> http://brandonlive.com/2010/02/21/measuring-memory-usage-in-windows-7/ <http://brandonlive.com/2010/02/21/measuring-memory-usage-in-windows-7/>), but Windows doesn’t let to distinguish between “cached and buffers” as far as I see. Thanks for the input, Yan. That's definitely good to know. Tomas > > Best regards, > Yan. > > > On 20 Sep 2017, at 19:05, Tomáš Golembiovský <tgolembi@redhat.com> wrote: > > > > Signed-off-by: Tomáš Golembiovský <tgolembi@redhat.com> > > --- > > hw/virtio/virtio-balloon.c | 2 ++ > > include/standard-headers/linux/virtio_balloon.h | 4 +++- > > 2 files changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/hw/virtio/virtio-balloon.c b/hw/virtio/virtio-balloon.c > > index a705e0ec55..0434784c14 100644 > > --- a/hw/virtio/virtio-balloon.c > > +++ b/hw/virtio/virtio-balloon.c > > @@ -49,6 +49,8 @@ static const char *balloon_stat_names[] = { > > [VIRTIO_BALLOON_S_MEMFREE] = "stat-free-memory", > > [VIRTIO_BALLOON_S_MEMTOT] = "stat-total-memory", > > [VIRTIO_BALLOON_S_AVAIL] = "stat-available-memory", > > + [VIRTIO_BALLOON_S_BUFFERS] = "stat-linux-buffers", > > + [VIRTIO_BALLOON_S_CACHED] = "stat-linux-cached", > > [VIRTIO_BALLOON_S_NR] = NULL > > }; > > > > diff --git a/include/standard-headers/linux/virtio_balloon.h b/include/standard-headers/linux/virtio_balloon.h > > index 9d06ccd066..d61efbfcee 100644 > > --- a/include/standard-headers/linux/virtio_balloon.h > > +++ b/include/standard-headers/linux/virtio_balloon.h > > @@ -52,7 +52,9 @@ struct virtio_balloon_config { > > #define VIRTIO_BALLOON_S_MEMFREE 4 /* Total amount of free memory */ > > #define VIRTIO_BALLOON_S_MEMTOT 5 /* Total amount of memory */ > > #define VIRTIO_BALLOON_S_AVAIL 6 /* Available memory as in /proc */ > > -#define VIRTIO_BALLOON_S_NR 7 > > +#define VIRTIO_BALLOON_S_BUFFERS 7 /* Buffers memory as in /proc */ > > +#define VIRTIO_BALLOON_S_CACHED 8 /* Cached memory as in /proc */ > > +#define VIRTIO_BALLOON_S_NR 9 > > > > /* > > * Memory statistics structure. > > -- > > 2.14.1 > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org > > For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org > > > -- Tomáš Golembiovský <tgolembi@redhat.com> ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-16 14:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-09-20 16:05 [Qemu-devel] [PATCH 0/1] Buffers/caches in VirtIO Balloon driver stats Tomáš Golembiovský 2017-09-20 16:05 ` [Qemu-devel] [PATCH 1/1] virtio-balloon: include buffers and chached memory statistics Tomáš Golembiovský 2017-11-16 13:38 ` [Qemu-devel] [virtio-dev] " Yan Vugenfirer 2017-11-16 14:07 ` Tomáš Golembiovský
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).