From: Jeff Cody <jcody@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, jsnow@redhat.com, stefanha@redhat.com,
kwolf@redhat.com, eblake@redhat.com
Subject: [Qemu-devel] [PATCH v5 00/10] qemu-iotests improvements
Date: Tue, 17 Oct 2017 12:31:45 -0400 [thread overview]
Message-ID: <cover.1508257445.git.jcody@redhat.com> (raw)
Previous series subject: "qemu-iotests: place output in unique dir"
Changes v4 -> v5:
-------------------
Relatively minor changes:
* line-too-long complaint by patchew
* fixed running from out-of-tree
* fixed 2 other bugs found: one test was forgotten,
and some QEMU process FIFOs were left behind.
* output formatting changes
git-backport-diff -r qemu/master.. -u devel-iotests-v4
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/10:[----] [--] 'qemu-iotests: refuse to run if TEST_DIR contains spaces'
002/10:[0012] [FC] 'qemu-iotests: set TEST_DIR to a unique dir for each test'
003/10:[----] [-C] 'qemu-iotests: automatically clean up bash protocol servers'
004/10:[----] [--] 'qemu-iotests: remove file cleanup from bash tests'
005/10:[0064] [FC] 'qemu-iotests: change qemu pid and fd tracking / cleanup'
006/10:[0007] [FC] 'qemu-iotests: make ./check automatically reap QEMU processes'
007/10:[0003] [FC] 'qemu-iotests: run python tests in own subdirectories'
008/10:[0002] [FC] 'qemu-iotests: modify python tests to run from subdir'
009/10:[----] [--] 'qemu-iotests: add option to save temp files on error'
010/10:[0066] [FC] 'qemu-iotests: add support for running multi-threaded iotests'
Changes v3 -> v4:
-------------------
Significant changes from v3. Highlights of the major changes from v3:
* Python tests are properly run in hierarchial sub-directories now
(Thanks Stefan, John)
* Protocol servers are cleaned up automatically (Thanks Kevin)
* Prevent running qemu-iotests if TEST_DIR contains spaces
* common.qemu process reaping overhauled, and qemu processes
also automatically killed on test conclusion
* multi-thread iotest job support. Here is an example of the
speedup:
Previous, single-thread run of everything qcow2:
# ./check -qcow2
[...]
Not run: 045 059 064 070 075 076 077 078 081 083 084 088 092 093 094 101
106 109 113 116 119 123 128 131 135 136 146 148 149 160 171 173 175
Failures: 191
Failed 1 of 149 tests
real 8m22.077s
user 4m48.177s
sys 1m16.553s
Multi-process run:
# ./check -qcow2 -j 5
[...]
Not run: 045 059 064 070 075 076 077 078 081 083 084 088 092 093 094 101
106 109 113 116 119 123 128 131 135 136 146 148 149 160 171 173 175
Failures: 183 191
Failed 2 of 149 tests
real 3m7.458s
user 5m29.678s
sys 1m55.007s
(See commit message on patch 10 for why there is an additional test
failure)
git-backport-diff -r qemu/master.. -u devel-iotests-v3
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/10:[down] 'qemu-iotests: refuse to run if TEST_DIR contains spaces'
002/10:[----] [--] 'qemu-iotests: set TEST_DIR to a unique dir for each test'
003/10:[down] 'qemu-iotests: automatically clean up bash protocol servers'
004/10:[0073] [FC] 'qemu-iotests: remove file cleanup from bash tests'
005/10:[down] 'qemu-iotests: change qemu pid and fd tracking / cleanup'
006/10:[down] 'qemu-iotests: make ./check automatically reap QEMU processes'
007/10:[down] 'qemu-iotests: run python tests in own subdirectories'
008/10:[down] 'qemu-iotests: modify python tests to run from subdir'
009/10:[0017] [FC] 'qemu-iotests: add option to save temp files on error'
010/10:[down] 'qemu-iotests: add support for running multi-threaded iotests'
Jeff Cody (10):
qemu-iotests: refuse to run if TEST_DIR contains spaces
qemu-iotests: set TEST_DIR to a unique dir for each test
qemu-iotests: automatically clean up bash protocol servers
qemu-iotests: remove file cleanup from bash tests
qemu-iotests: change qemu pid and fd tracking / cleanup
qemu-iotests: make ./check automatically reap QEMU processes
qemu-iotests: run python tests in own subdirectories
qemu-iotests: modify python tests to run from subdir
qemu-iotests: add option to save temp files on error
qemu-iotests: add support for running multi-threaded iotests
tests/qemu-iotests/001 | 6 -
tests/qemu-iotests/002 | 6 -
tests/qemu-iotests/003 | 6 -
tests/qemu-iotests/004 | 6 -
tests/qemu-iotests/005 | 6 -
tests/qemu-iotests/007 | 7 -
tests/qemu-iotests/008 | 6 -
tests/qemu-iotests/009 | 6 -
tests/qemu-iotests/010 | 6 -
tests/qemu-iotests/011 | 6 -
tests/qemu-iotests/012 | 6 -
tests/qemu-iotests/013 | 6 -
tests/qemu-iotests/014 | 6 -
tests/qemu-iotests/015 | 7 -
tests/qemu-iotests/017 | 6 -
tests/qemu-iotests/018 | 6 -
tests/qemu-iotests/019 | 8 -
tests/qemu-iotests/020 | 8 -
tests/qemu-iotests/021 | 6 -
tests/qemu-iotests/022 | 6 -
tests/qemu-iotests/023 | 6 -
tests/qemu-iotests/024 | 8 -
tests/qemu-iotests/025 | 6 -
tests/qemu-iotests/026 | 7 -
tests/qemu-iotests/027 | 6 -
tests/qemu-iotests/028 | 8 -
tests/qemu-iotests/029 | 7 -
tests/qemu-iotests/030 | 82 ++++-----
tests/qemu-iotests/031 | 6 -
tests/qemu-iotests/032 | 6 -
tests/qemu-iotests/033 | 6 -
tests/qemu-iotests/034 | 6 -
tests/qemu-iotests/035 | 6 -
tests/qemu-iotests/036 | 6 -
tests/qemu-iotests/037 | 6 -
tests/qemu-iotests/038 | 6 -
tests/qemu-iotests/039 | 6 -
tests/qemu-iotests/040 | 128 ++++++-------
tests/qemu-iotests/041 | 333 ++++++++++++++++-----------------
tests/qemu-iotests/042 | 6 -
tests/qemu-iotests/043 | 7 -
tests/qemu-iotests/044 | 11 +-
tests/qemu-iotests/045 | 42 ++---
tests/qemu-iotests/046 | 6 -
tests/qemu-iotests/047 | 6 -
tests/qemu-iotests/048 | 8 -
tests/qemu-iotests/048.out | 1 -
tests/qemu-iotests/049 | 6 -
tests/qemu-iotests/050 | 8 -
tests/qemu-iotests/051 | 6 -
tests/qemu-iotests/052 | 6 -
tests/qemu-iotests/053 | 7 -
tests/qemu-iotests/054 | 6 -
tests/qemu-iotests/055 | 97 +++++-----
tests/qemu-iotests/056 | 39 ++--
tests/qemu-iotests/057 | 4 +-
tests/qemu-iotests/058 | 47 ++---
tests/qemu-iotests/059 | 7 -
tests/qemu-iotests/060 | 6 -
tests/qemu-iotests/061 | 6 -
tests/qemu-iotests/062 | 6 -
tests/qemu-iotests/063 | 7 -
tests/qemu-iotests/064 | 6 -
tests/qemu-iotests/065 | 13 +-
tests/qemu-iotests/066 | 6 -
tests/qemu-iotests/068 | 6 -
tests/qemu-iotests/069 | 6 -
tests/qemu-iotests/070 | 6 -
tests/qemu-iotests/071 | 6 -
tests/qemu-iotests/072 | 6 -
tests/qemu-iotests/073 | 6 -
tests/qemu-iotests/074 | 9 -
tests/qemu-iotests/074.out | 1 -
tests/qemu-iotests/075 | 6 -
tests/qemu-iotests/076 | 6 -
tests/qemu-iotests/077 | 6 -
tests/qemu-iotests/078 | 6 -
tests/qemu-iotests/079 | 6 -
tests/qemu-iotests/080 | 7 -
tests/qemu-iotests/081 | 8 -
tests/qemu-iotests/082 | 6 -
tests/qemu-iotests/083 | 8 -
tests/qemu-iotests/084 | 6 -
tests/qemu-iotests/085 | 13 --
tests/qemu-iotests/086 | 6 -
tests/qemu-iotests/088 | 7 -
tests/qemu-iotests/089 | 6 -
tests/qemu-iotests/090 | 6 -
tests/qemu-iotests/091 | 8 -
tests/qemu-iotests/092 | 7 -
tests/qemu-iotests/094 | 9 -
tests/qemu-iotests/095 | 8 -
tests/qemu-iotests/096 | 8 +-
tests/qemu-iotests/097 | 7 -
tests/qemu-iotests/098 | 7 -
tests/qemu-iotests/099 | 6 -
tests/qemu-iotests/101 | 6 -
tests/qemu-iotests/102 | 7 -
tests/qemu-iotests/103 | 6 -
tests/qemu-iotests/104 | 2 -
tests/qemu-iotests/105 | 6 -
tests/qemu-iotests/106 | 6 -
tests/qemu-iotests/107 | 6 -
tests/qemu-iotests/108 | 6 -
tests/qemu-iotests/109 | 8 -
tests/qemu-iotests/110 | 6 -
tests/qemu-iotests/111 | 6 -
tests/qemu-iotests/112 | 6 -
tests/qemu-iotests/113 | 6 -
tests/qemu-iotests/114 | 6 -
tests/qemu-iotests/115 | 6 -
tests/qemu-iotests/116 | 6 -
tests/qemu-iotests/117 | 7 -
tests/qemu-iotests/118 | 200 ++++++++++----------
tests/qemu-iotests/119 | 6 -
tests/qemu-iotests/120 | 6 -
tests/qemu-iotests/121 | 6 -
tests/qemu-iotests/122 | 7 -
tests/qemu-iotests/123 | 7 -
tests/qemu-iotests/124 | 24 +--
tests/qemu-iotests/125 | 6 -
tests/qemu-iotests/129 | 6 +-
tests/qemu-iotests/130 | 7 -
tests/qemu-iotests/131 | 6 -
tests/qemu-iotests/132 | 19 +-
tests/qemu-iotests/133 | 6 -
tests/qemu-iotests/134 | 6 -
tests/qemu-iotests/135 | 6 -
tests/qemu-iotests/136 | 7 +-
tests/qemu-iotests/137 | 6 -
tests/qemu-iotests/138 | 6 -
tests/qemu-iotests/139 | 33 ++--
tests/qemu-iotests/140 | 8 -
tests/qemu-iotests/141 | 8 -
tests/qemu-iotests/142 | 7 -
tests/qemu-iotests/143 | 7 -
tests/qemu-iotests/144 | 8 -
tests/qemu-iotests/145 | 7 -
tests/qemu-iotests/146 | 7 -
tests/qemu-iotests/147 | 41 ++---
tests/qemu-iotests/148 | 33 ++--
tests/qemu-iotests/150 | 6 -
tests/qemu-iotests/152 | 21 +--
tests/qemu-iotests/153 | 12 --
tests/qemu-iotests/154 | 6 -
tests/qemu-iotests/155 | 54 +++---
tests/qemu-iotests/156 | 7 -
tests/qemu-iotests/157 | 6 -
tests/qemu-iotests/158 | 6 -
tests/qemu-iotests/159 | 7 -
tests/qemu-iotests/160 | 7 -
tests/qemu-iotests/162 | 7 -
tests/qemu-iotests/163 | 42 ++---
tests/qemu-iotests/165 | 11 +-
tests/qemu-iotests/170 | 7 -
tests/qemu-iotests/171 | 6 -
tests/qemu-iotests/172 | 8 -
tests/qemu-iotests/173 | 8 -
tests/qemu-iotests/174 | 6 -
tests/qemu-iotests/175 | 6 -
tests/qemu-iotests/176 | 7 -
tests/qemu-iotests/177 | 6 -
tests/qemu-iotests/178 | 7 -
tests/qemu-iotests/179 | 7 -
tests/qemu-iotests/181 | 8 -
tests/qemu-iotests/182 | 6 -
tests/qemu-iotests/183 | 9 -
tests/qemu-iotests/184 | 6 -
tests/qemu-iotests/185 | 9 -
tests/qemu-iotests/186 | 6 -
tests/qemu-iotests/187 | 8 -
tests/qemu-iotests/188 | 6 -
tests/qemu-iotests/189 | 6 -
tests/qemu-iotests/190 | 7 -
tests/qemu-iotests/191 | 10 -
tests/qemu-iotests/192 | 6 -
tests/qemu-iotests/195 | 7 -
tests/qemu-iotests/197 | 7 -
tests/qemu-iotests/check | 409 +++++++++++++++++++++++++++++++----------
tests/qemu-iotests/common.qemu | 82 +++++++--
tests/qemu-iotests/common.rc | 98 ++++++----
tests/qemu-iotests/iotests.py | 15 +-
182 files changed, 1044 insertions(+), 1869 deletions(-)
--
2.9.5
next reply other threads:[~2017-10-17 16:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-17 16:31 Jeff Cody [this message]
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 01/10] qemu-iotests: refuse to run if TEST_DIR contains spaces Jeff Cody
2017-10-18 1:03 ` Eric Blake
2017-10-18 3:05 ` Jeff Cody
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 02/10] qemu-iotests: set TEST_DIR to a unique dir for each test Jeff Cody
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 03/10] qemu-iotests: automatically clean up bash protocol servers Jeff Cody
2017-10-18 1:15 ` Eric Blake
2017-10-18 14:46 ` Paolo Bonzini
2017-10-18 15:03 ` Jeff Cody
2017-10-18 15:16 ` Paolo Bonzini
2017-10-18 15:34 ` Jeff Cody
2017-10-18 15:39 ` Paolo Bonzini
2017-10-18 15:50 ` Jeff Cody
2017-10-18 15:51 ` Paolo Bonzini
2017-10-18 16:19 ` Jeff Cody
2017-10-18 16:39 ` Paolo Bonzini
2017-10-18 17:27 ` Jeff Cody
2017-10-19 10:23 ` Paolo Bonzini
2017-10-19 14:52 ` Jeff Cody
2017-10-19 21:03 ` Paolo Bonzini
2017-10-18 15:06 ` Eric Blake
2017-10-18 15:43 ` Daniel P. Berrange
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 04/10] qemu-iotests: remove file cleanup from bash tests Jeff Cody
2017-10-18 13:46 ` Eric Blake
2017-10-18 13:56 ` Jeff Cody
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 05/10] qemu-iotests: change qemu pid and fd tracking / cleanup Jeff Cody
2017-10-18 13:59 ` Jeff Cody
2017-10-18 14:11 ` Eric Blake
2017-10-18 14:22 ` Eric Blake
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 06/10] qemu-iotests: make ./check automatically reap QEMU processes Jeff Cody
2017-10-18 14:24 ` Eric Blake
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 07/10] qemu-iotests: run python tests in own subdirectories Jeff Cody
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 08/10] qemu-iotests: modify python tests to run from subdir Jeff Cody
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 09/10] qemu-iotests: add option to save temp files on error Jeff Cody
2017-10-18 14:33 ` Eric Blake
2017-10-17 16:31 ` [Qemu-devel] [PATCH v5 10/10] qemu-iotests: add support for running multi-threaded iotests Jeff Cody
2017-10-18 3:45 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1508257445.git.jcody@redhat.com \
--to=jcody@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).