From: Jason Baron <jbaron@akamai.com>
To: mst@redhat.com
Cc: davem@davemloft.net, jasowang@redhat.com, netdev@vger.kernel.org,
virtualization@lists.linux-foundation.org, qemu-devel@nongnu.org,
virtio-dev@lists.oasis-open.org
Subject: [Qemu-devel] [PATCH v4 0/3] virtio_net: allow hypervisor to indicate linkspeed and duplex setting
Date: Fri, 5 Jan 2018 17:44:52 -0500 [thread overview]
Message-ID: <cover.1515190238.git.jbaron@akamai.com> (raw)
We have found it useful to be able to set the linkspeed and duplex
settings from the host-side for virtio_net. This obviates the need
for guest changes and settings for these fields, and does not require
custom ethtool commands for virtio_net.
The ability to set linkspeed and duplex is useful in various cases
as described here:
16032be virtio_net: add ethtool support for set and get of settings
Using 'ethtool -s' continues to over-write the linkspeed/duplex
settings with this patch.
The 1/3 patch is against net-next, while the 2-3/3 patch are the associated
qemu changes that would go in after as update-linux-headers.sh should
be run first. So the qemu patches are a demonstration of how I intend this
to work.
Thanks,
-Jason
linux changes:
changes from v3:
* break the speed/duplex read into a function and also call from virtnet_probe
when status bit is not negotiated
* only do speed/duplex read in virtnet_config_changed_work() on LINK_UP
changes from v2:
* move speed/duplex read into virtnet_config_changed_work() so link up changes
are detected
Jason Baron (1):
virtio_net: propagate linkspeed/duplex settings from the hypervisor
drivers/net/virtio_net.c | 23 ++++++++++++++++++++++-
include/uapi/linux/virtio_net.h | 13 +++++++++++++
2 files changed, 35 insertions(+), 1 deletion(-)
qemu changes:
Jason Baron (2):
qemu: virtio-net: use 64-bit values for feature flags
qemu: add linkspeed and duplex settings to virtio-net
hw/net/virtio-net.c | 87 ++++++++++++++++++++---------
include/hw/virtio/virtio-net.h | 5 +-
include/standard-headers/linux/virtio_net.h | 13 +++++
3 files changed, 77 insertions(+), 28 deletions(-)
--
2.6.1
next reply other threads:[~2018-01-05 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 22:44 Jason Baron [this message]
2018-01-05 22:44 ` [Qemu-devel] [PATCH v4 2/3] qemu: virtio-net: use 64-bit values for feature flags Jason Baron
2018-01-05 22:44 ` [Qemu-devel] [PATCH net-next v4 1/3] virtio_net: propagate linkspeed/duplex settings from the hypervisor Jason Baron
2018-01-09 16:38 ` David Miller
2018-01-05 22:44 ` [Qemu-devel] [PATCH v4 3/3] qemu: add linkspeed and duplex settings to virtio-net Jason Baron
2018-02-08 16:39 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1515190238.git.jbaron@akamai.com \
--to=jbaron@akamai.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).