qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Alberto Garcia <berto@igalia.com>,
	qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH v2 00/10] Misc reopen-related patches
Date: Mon,  3 Sep 2018 17:33:58 +0300	[thread overview]
Message-ID: <cover.1535983918.git.berto@igalia.com> (raw)

Hi,

as part of my blockdev-reopen work here's a new set of patches. This
doesn't implement yet the core functionality of the new reopen
command, but it does fix a few things that help us pave the way.
I believe that the next series after this one will be the last.

The main change is the removal of child references from the options
and explicit_options QDicts. This was already discussed in the
previous series[1], and here's the implementation.

Regards,

Berto

[1] https://lists.gnu.org/archive/html/qemu-block/2018-08/msg00474.html

v2:
- Patches 3 and 5: Make comments more explicit. [Max]
- Patch 6: Use qemu_opts_to_qdict() in bdrv_reopen_prepare() to put
  all unprocessed options back into the QDict. [Max]
- Patches 8-10: Use qemu_opt_get_del() and update commit messages to
  reflect the changes in patch 6. [Max]

v1: https://lists.gnu.org/archive/html/qemu-block/2018-08/msg00846.html
- Initial version

Output of backport-diff against v1:

Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively

001/10:[----] [--] 'qemu-io: Fix writethrough check in reopen'
002/10:[----] [--] 'file-posix: x-check-cache-dropped should default to false on reopen'
003/10:[0003] [FC] 'block: Remove child references from bs->{options,explicit_options}'
004/10:[----] [--] 'block: Don't look for child references in append_open_options()'
005/10:[0005] [FC] 'block: Allow child references on reopen'
006/10:[down] 'block: Forbid trying to change unsupported options during reopen'
007/10:[----] [--] 'file-posix: Forbid trying to change unsupported options during reopen'
008/10:[0003] [FC] 'block: Allow changing 'discard' on reopen'
009/10:[0002] [FC] 'block: Allow changing 'detect-zeroes' on reopen'
010/10:[0002] [FC] 'block: Allow changing 'force-share' on reopen'

Alberto Garcia (10):
  qemu-io: Fix writethrough check in reopen
  file-posix: x-check-cache-dropped should default to false on reopen
  block: Remove child references from bs->{options,explicit_options}
  block: Don't look for child references in append_open_options()
  block: Allow child references on reopen
  block: Forbid trying to change unsupported options during reopen
  file-posix: Forbid trying to change unsupported options during reopen
  block: Allow changing 'discard' on reopen
  block: Allow changing 'detect-zeroes' on reopen
  block: Allow changing 'force-share' on reopen

 block.c               | 161 +++++++++++++++++++++++++++++++++-----------------
 block/file-posix.c    |   9 ++-
 include/block/block.h |   2 +
 qemu-io-cmds.c        |   2 +-
 4 files changed, 117 insertions(+), 57 deletions(-)

-- 
2.11.0

             reply	other threads:[~2018-09-03 14:35 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 14:33 Alberto Garcia [this message]
2018-09-03 14:33 ` [Qemu-devel] [PATCH v2 01/10] qemu-io: Fix writethrough check in reopen Alberto Garcia
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 02/10] file-posix: x-check-cache-dropped should default to false on reopen Alberto Garcia
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 03/10] block: Remove child references from bs->{options, explicit_options} Alberto Garcia
2018-09-05 12:37   ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 04/10] block: Don't look for child references in append_open_options() Alberto Garcia
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 05/10] block: Allow child references on reopen Alberto Garcia
2018-09-05 12:40   ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 06/10] block: Forbid trying to change unsupported options during reopen Alberto Garcia
2018-09-05 12:48   ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 07/10] file-posix: " Alberto Garcia
2018-09-05 12:49   ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 08/10] block: Allow changing 'discard' on reopen Alberto Garcia
2018-09-05 12:50   ` Max Reitz
2018-09-05 16:53   ` Alberto Garcia
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 09/10] block: Allow changing 'detect-zeroes' " Alberto Garcia
2018-09-05 12:52   ` Max Reitz
2018-09-03 14:34 ` [Qemu-devel] [PATCH v2 10/10] block: Allow changing 'force-share' " Alberto Garcia
2018-09-05 12:56   ` Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1535983918.git.berto@igalia.com \
    --to=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).