From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gD2Up-0004No-Rz for qemu-devel@nongnu.org; Thu, 18 Oct 2018 03:13:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gD2Uk-00083e-UI for qemu-devel@nongnu.org; Thu, 18 Oct 2018 03:13:27 -0400 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]:44888) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gD2Ui-0007w5-Vt for qemu-devel@nongnu.org; Thu, 18 Oct 2018 03:13:21 -0400 Received: by mail-lj1-x242.google.com with SMTP id v6-v6so26678594ljc.11 for ; Thu, 18 Oct 2018 00:13:19 -0700 (PDT) From: Artem Pisarenko Date: Thu, 18 Oct 2018 13:12:51 +0600 Message-Id: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH v3 0/4] Fix and improve core RTC function and documentation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Artem Pisarenko Modifications are motivated by bug https://bugs.launchpad.net/qemu/+bug/1797033 I've encountered recently. Trying to fix it and analyzing its effect on all use cases (not covered in bug report) revealed much deeper problems. This is my first patch to QEMU and I'm not sure whether the way I addressed them is proper. They definitely require either modifications to current implementation (breaking compability), or adding clarifications to user documentation. I've tried to find compromise. Changes I propose are driven mostly by my interpretation of user documentation and comments in code, rather than by existing implementation. I've splitted patches in a way that at least some of them may be accepted. Following subsets are make sense on their own: - 1 - 1,2,3 I limited refactoring only to vl.c, although it leads to reworking of all hw/* rtc models which have unreasonable duplications of actions performed by vl.c. I'm sure such kind of rework will reveal more hidden bugs/features, but so far I've had enough (it's a long story how muсh effort and pain cost me to find that tricky bug above). I suppose just to draw attention of relevant hw/* maintainers. v3 changes: - commit messages rewritten/shortened/wrapped to match patch requirements - fixed minor typo v2 changes: - fixed compiler warning caused non-debug build fail Artem Pisarenko (4): vl: improve/fix documentation related to RTC function vl: refactor -rtc option references Fixes RTC bug with base datetime shifts in clock=vm vl,qapi: offset calculation in RTC_CHANGE event reverted qapi/misc.json | 3 +- qemu-options.hx | 14 +++++--- vl.c | 105 +++++++++++++++++++++++++++++++++++++------------------- 3 files changed, 80 insertions(+), 42 deletions(-) -- 2.7.4