From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: "Alberto Garcia" <berto@igalia.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [Qemu-devel] [PATCH v2 0/3] char-socket: Fix race condition
Date: Fri, 22 Feb 2019 13:59:09 +0200 [thread overview]
Message-ID: <cover.1550836631.git.berto@igalia.com> (raw)
This fixes a race condition in which the tcp_chr_read() ioc handler
can close a connection that is being written to from another thread.
This is essentially v1 rebased on top of the current master, after
Daniel and Marc-André's chardev series have been merged.
Note: vhost-user-test still fails if QTEST_VHOST_USER_FIXME is set.
Berto
RFC: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01510.html
v1: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01834.html
- Fixes memory leaks and adds a qemu_idle_add() function
v2:
- Rebased on top of the current master (fc3dbb90f2eb069801bfb4cfe9cbc)
- Patches 1 and 2: Remove the changes in char-pty.c, they're not
needed after the rebase.
- Patch 3: Fix conflicts after the rebase.
git backport-diff against v1:
Key:
[----] : patches are identical
[####] : number of functional differences between upstream/downstream patch
[down] : patch is downstream-only
The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
001/3:[down] 'main-loop: Fix GSource leak in qio_task_thread_worker()'
002/3:[0027] [FC] 'main-loop: Add qemu_idle_add()'
003/3:[0004] [FC] 'char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()'
Alberto Garcia (3):
main-loop: Fix GSource leak in qio_task_thread_worker()
main-loop: Add qemu_idle_add()
char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout()
chardev/char-socket.c | 19 +++++++++++++++++--
include/qemu/main-loop.h | 12 ++++++++++++
io/task.c | 9 +++------
util/main-loop.c | 9 +++++++++
4 files changed, 41 insertions(+), 8 deletions(-)
--
2.11.0
next reply other threads:[~2019-02-22 12:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 11:59 Alberto Garcia [this message]
2019-02-22 11:59 ` [Qemu-devel] [PATCH v2 1/3] main-loop: Fix GSource leak in qio_task_thread_worker() Alberto Garcia
2019-02-22 12:08 ` Daniel P. Berrangé
2019-02-22 11:59 ` [Qemu-devel] [PATCH v2 2/3] main-loop: Add qemu_idle_add() Alberto Garcia
2019-02-22 12:10 ` Daniel P. Berrangé
2019-02-22 11:59 ` [Qemu-devel] [PATCH v2 3/3] char-socket: Lock tcp_chr_disconnect() and socket_reconnect_timeout() Alberto Garcia
2019-02-22 12:16 ` Daniel P. Berrangé
2019-02-22 12:32 ` Alberto Garcia
2019-02-22 12:36 ` [Qemu-devel] [PATCH v2 0/3] char-socket: Fix race condition Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1550836631.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=berrange@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).