* [PATCH v2 0/1] Fix bochs memory leak
@ 2019-12-10 21:27 Cameron Esfahani via
2019-12-10 21:27 ` [PATCH v2 1/1] display/bochs-display: fix " Cameron Esfahani via
0 siblings, 1 reply; 5+ messages in thread
From: Cameron Esfahani via @ 2019-12-10 21:27 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel
Fix a small memory leak in the Bochs display driver.
Each frame would leak about 304 bytes.
v2: Add missing signed-off-by line.
Cameron Esfahani (1):
display/bochs-display: fix memory leak
hw/display/bochs-display.c | 2 ++
1 file changed, 2 insertions(+)
--
2.24.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/1] display/bochs-display: fix memory leak
2019-12-10 21:27 [PATCH v2 0/1] Fix bochs memory leak Cameron Esfahani via
@ 2019-12-10 21:27 ` Cameron Esfahani via
2019-12-10 23:16 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Cameron Esfahani via @ 2019-12-10 21:27 UTC (permalink / raw)
To: qemu-devel; +Cc: kraxel
Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame.
Signed-off-by: Cameron Esfahani <dirty@apple.com>
---
hw/display/bochs-display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
index dc1bd1641d..215db9a231 100644
--- a/hw/display/bochs-display.c
+++ b/hw/display/bochs-display.c
@@ -252,6 +252,8 @@ static void bochs_display_update(void *opaque)
dpy_gfx_update(s->con, 0, ys,
mode.width, y - ys);
}
+
+ g_free(snap);
}
}
--
2.24.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2 1/1] display/bochs-display: fix memory leak
2019-12-10 21:27 ` [PATCH v2 1/1] display/bochs-display: fix " Cameron Esfahani via
@ 2019-12-10 23:16 ` Philippe Mathieu-Daudé
2019-12-10 23:28 ` Aleksandar Markovic
0 siblings, 1 reply; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-10 23:16 UTC (permalink / raw)
To: Cameron Esfahani, qemu-devel; +Cc: kraxel
On 12/10/19 10:27 PM, Cameron Esfahani via wrote:
> Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame.
>
> Signed-off-by: Cameron Esfahani <dirty@apple.com>
Funny to have a dirty@ email fixing a DirtyBitmapSnapshot leak =)
Fixes: 33ebad54056
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> ---
> hw/display/bochs-display.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
> index dc1bd1641d..215db9a231 100644
> --- a/hw/display/bochs-display.c
> +++ b/hw/display/bochs-display.c
> @@ -252,6 +252,8 @@ static void bochs_display_update(void *opaque)
> dpy_gfx_update(s->con, 0, ys,
> mode.width, y - ys);
> }
> +
> + g_free(snap);
> }
> }
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] display/bochs-display: fix memory leak
2019-12-10 23:16 ` Philippe Mathieu-Daudé
@ 2019-12-10 23:28 ` Aleksandar Markovic
2019-12-10 23:35 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 5+ messages in thread
From: Aleksandar Markovic @ 2019-12-10 23:28 UTC (permalink / raw)
To: Philippe Mathieu-Daudé
Cc: qemu-devel@nongnu.org, Cameron Esfahani, kraxel@redhat.com
[-- Attachment #1: Type: text/plain, Size: 1029 bytes --]
On Wednesday, December 11, 2019, Philippe Mathieu-Daudé <philmd@redhat.com>
wrote:
> On 12/10/19 10:27 PM, Cameron Esfahani via wrote:
>
>> Fix memory leak in bochs_display_update(). Leaks 304 bytes per frame.
>>
>> Signed-off-by: Cameron Esfahani <dirty@apple.com>
>>
>
> Funny to have a dirty@ email fixing a DirtyBitmapSnapshot leak =)
>
> Fixes: 33ebad54056
Dirty fixing bad in a snap. What a fix. :-o
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>
> ---
>> hw/display/bochs-display.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/hw/display/bochs-display.c b/hw/display/bochs-display.c
>> index dc1bd1641d..215db9a231 100644
>> --- a/hw/display/bochs-display.c
>> +++ b/hw/display/bochs-display.c
>> @@ -252,6 +252,8 @@ static void bochs_display_update(void *opaque)
>> dpy_gfx_update(s->con, 0, ys,
>> mode.width, y - ys);
>> }
>> +
>> + g_free(snap);
>> }
>> }
>>
>>
>
>
>
[-- Attachment #2: Type: text/html, Size: 1773 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 1/1] display/bochs-display: fix memory leak
2019-12-10 23:28 ` Aleksandar Markovic
@ 2019-12-10 23:35 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-12-10 23:35 UTC (permalink / raw)
To: Aleksandar Markovic
Cc: qemu-devel@nongnu.org, Cameron Esfahani, kraxel@redhat.com
On 12/11/19 12:28 AM, Aleksandar Markovic wrote:
>
> On Wednesday, December 11, 2019, Philippe Mathieu-Daudé
> <philmd@redhat.com <mailto:philmd@redhat.com>> wrote:
>
> On 12/10/19 10:27 PM, Cameron Esfahani via wrote:
>
> Fix memory leak in bochs_display_update(). Leaks 304 bytes per
> frame.
>
> Signed-off-by: Cameron Esfahani <dirty@apple.com
> <mailto:dirty@apple.com>>
>
>
> Funny to have a dirty@ email fixing a DirtyBitmapSnapshot leak =)
>
> Fixes: 33ebad54056
>
>
> Dirty fixing bad in a snap. What a fix. :-o
Nice one! =)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-10 23:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-10 21:27 [PATCH v2 0/1] Fix bochs memory leak Cameron Esfahani via
2019-12-10 21:27 ` [PATCH v2 1/1] display/bochs-display: fix " Cameron Esfahani via
2019-12-10 23:16 ` Philippe Mathieu-Daudé
2019-12-10 23:28 ` Aleksandar Markovic
2019-12-10 23:35 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).