From: Finn Thain <fthain@telegraphics.com.au>
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: "Aleksandar Rikalo" <aleksandar.rikalo@rt-rk.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Laurent Vivier" <laurent@vivier.eu>,
qemu-stable@nongnu.org
Subject: [PATCH v2 00/13] Fixes for DP8393X SONIC device emulation
Date: Fri, 20 Dec 2019 15:17:46 +1100 [thread overview]
Message-ID: <cover.1576815466.git.fthain@telegraphics.com.au> (raw)
Hi All,
There are bugs in the DP8393X emulation that can stop packet reception.
Whilst debugging the device I found that the receiver algorithm differs
from the one described in the National Semiconductor datasheet.
These issues and others are addressed by this patch series.
This series has only been tested with Linux/m68k guests. It needs further
testing with MIPS Magnum guests such as NetBSD or Windows NT.
Note that the mainline Linux sonic driver also has bugs.
Those bugs have been fixed in a series of patches at,
https://github.com/fthain/linux/commits/mac68k
---
Changed since v1:
- Minor revisions described in patch descriptions.
- Dropped patches 4/10 and 7/10.
- Added 5 new patches.
Finn Thain (13):
dp8393x: Mask EOL bit from descriptor addresses
dp8393x: Clean up endianness hacks
dp8393x: Have dp8393x_receive() return the packet size
dp8393x: Update LLFA and CRDA registers from rx descriptor
dp8393x: Clear RRRA command register bit only when appropriate
dp8393x: Implement packet size limit and RBAE interrupt
dp8393x: Don't stop reception upon RBE interrupt assertion
dp8393x: Don't clobber packet checksum
dp8393x: Use long-word-aligned RRA pointers in 32-bit mode
dp8393x: Pad frames to word or long word boundary
dp8393x: Clear descriptor in_use field when necessary
dp8393x: Always update RRA pointers and sequence numbers
dp8393x: Correctly advance RRP
hw/net/dp8393x.c | 147 ++++++++++++++++++++++++++++++++---------------
1 file changed, 100 insertions(+), 47 deletions(-)
--
2.23.0
next reply other threads:[~2019-12-20 4:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 4:17 Finn Thain [this message]
2019-12-20 4:17 ` [PATCH v2 03/13] dp8393x: Have dp8393x_receive() return the packet size Finn Thain
2019-12-20 4:17 ` [PATCH v2 07/13] dp8393x: Don't stop reception upon RBE interrupt assertion Finn Thain
2019-12-20 4:17 ` [PATCH v2 11/13] dp8393x: Clear descriptor in_use field when necessary Finn Thain
2019-12-20 4:17 ` [PATCH v2 08/13] dp8393x: Don't clobber packet checksum Finn Thain
2019-12-20 4:17 ` [PATCH v2 10/13] dp8393x: Pad frames to word or long word boundary Finn Thain
2019-12-20 4:17 ` [PATCH v2 05/13] dp8393x: Clear RRRA command register bit only when appropriate Finn Thain
2019-12-20 4:17 ` [PATCH v2 01/13] dp8393x: Mask EOL bit from descriptor addresses Finn Thain
2019-12-20 4:17 ` [PATCH v2 13/13] dp8393x: Correctly advance RRP Finn Thain
2019-12-20 22:15 ` Finn Thain
2019-12-20 4:17 ` [PATCH v2 02/13] dp8393x: Clean up endianness hacks Finn Thain
2020-01-06 22:19 ` Finn Thain
2020-01-07 7:20 ` Philippe Mathieu-Daudé
2020-01-08 0:21 ` Finn Thain
2019-12-20 4:17 ` [PATCH v2 12/13] dp8393x: Always update RRA pointers and sequence numbers Finn Thain
2019-12-20 4:17 ` [PATCH v2 04/13] dp8393x: Update LLFA and CRDA registers from rx descriptor Finn Thain
2019-12-20 4:17 ` [PATCH v2 09/13] dp8393x: Use long-word-aligned RRA pointers in 32-bit mode Finn Thain
2019-12-20 4:17 ` [PATCH v2 06/13] dp8393x: Implement packet size limit and RBAE interrupt Finn Thain
2019-12-20 10:16 ` [PATCH v2 00/13] Fixes for DP8393X SONIC device emulation Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1576815466.git.fthain@telegraphics.com.au \
--to=fthain@telegraphics.com.au \
--cc=aleksandar.rikalo@rt-rk.com \
--cc=hpoussin@reactos.org \
--cc=jasowang@redhat.com \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).