From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: [PATCH v8 0/7] 9pfs: readdir optimization
Date: Wed, 29 Jul 2020 10:53:07 +0200 [thread overview]
Message-ID: <cover.1596012787.git.qemu_oss@crudebyte.com> (raw)
As previously mentioned, I was investigating performance issues with 9pfs.
Raw file read/write of 9pfs is actually quite good, provided that client
picked a reasonable high msize (maximum message size). I would recommend
to log a warning on 9p server side if a client attached with a small msize
that would cause performance issues for that reason.
However there are other aspects where 9pfs currently performs suboptimally,
especially readdir handling of 9pfs is extremely slow, a simple readdir
request of a guest typically blocks for several hundred milliseconds or
even several seconds, no matter how powerful the underlying hardware is.
The reason for this performance issue: latency.
Currently 9pfs is heavily dispatching a T_readdir request numerous times
between main I/O thread and a background I/O thread back and forth; in fact
it is actually hopping between threads even multiple times for every single
directory entry during T_readdir request handling which leads in total to
huge latencies for a single T_readdir request.
This patch series aims to address this severe performance issue of 9pfs
T_readdir request handling. The actual performance optimization is patch 5.
v7->v8:
* Split previous patch 3 into two patches [patch 3], [patch 4].
* Error out if a 9p2000.u client sends a Treaddir request, likewise error
out if a 9p2000.L client sends a Tread request on a directory [patch 6].
Unchanged patches: [patch 1], [patch 2], [patch 5], [patch 7].
Message-ID of previous version (v7):
cover.1595166227.git.qemu_oss@crudebyte.com
Message-ID of version with performance benchmark (v4):
cover.1579567019.git.qemu_oss@crudebyte.com
Christian Schoenebeck (7):
tests/virtio-9p: added split readdir tests
9pfs: make v9fs_readdir_response_size() public
9pfs: split out fs driver core of v9fs_co_readdir()
9pfs: add new function v9fs_co_readdir_many()
9pfs: T_readdir latency optimization
9pfs: differentiate readdir lock between 9P2000.u vs. 9P2000.L
9pfs: clarify latency of v9fs_co_run_in_worker()
hw/9pfs/9p.c | 159 ++++++++++++++--------------
hw/9pfs/9p.h | 50 ++++++++-
hw/9pfs/codir.c | 196 +++++++++++++++++++++++++++++++++--
hw/9pfs/coth.h | 15 ++-
tests/qtest/virtio-9p-test.c | 108 +++++++++++++++++++
5 files changed, 434 insertions(+), 94 deletions(-)
--
2.20.1
next reply other threads:[~2020-07-29 9:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 8:53 Christian Schoenebeck [this message]
2020-07-29 8:10 ` [PATCH v8 1/7] tests/virtio-9p: added split readdir tests Christian Schoenebeck
2020-07-29 15:42 ` Greg Kurz
2020-07-29 17:24 ` Christian Schoenebeck
2020-07-29 8:11 ` [PATCH v8 2/7] 9pfs: make v9fs_readdir_response_size() public Christian Schoenebeck
2020-07-29 15:44 ` Greg Kurz
2020-07-29 8:11 ` [PATCH v8 3/7] 9pfs: split out fs driver core of v9fs_co_readdir() Christian Schoenebeck
2020-07-29 16:02 ` Greg Kurz
2020-07-29 17:38 ` Christian Schoenebeck
2020-07-29 8:12 ` [PATCH v8 4/7] 9pfs: add new function v9fs_co_readdir_many() Christian Schoenebeck
2020-07-30 10:08 ` Christian Schoenebeck
2020-08-06 9:38 ` Christian Schoenebeck
2020-07-29 8:13 ` [PATCH v8 5/7] 9pfs: T_readdir latency optimization Christian Schoenebeck
2020-07-29 8:39 ` [PATCH v8 6/7] 9pfs: differentiate readdir lock between 9P2000.u vs. 9P2000.L Christian Schoenebeck
2020-07-29 8:42 ` [PATCH v8 7/7] 9pfs: clarify latency of v9fs_co_run_in_worker() Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1596012787.git.qemu_oss@crudebyte.com \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).