qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Tomáš Golembiovský" <tgolembi@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrangé" <berrange@redhat.com>,
	"Michael Roth" <mdroth@linux.vnet.ibm.com>,
	"Yonggang Luo" <luoyonggang@gmail.com>,
	"Tomáš Golembiovský" <tgolembi@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: [PATCH v4 0/3] qga: add command guest-get-disks
Date: Mon, 12 Oct 2020 10:36:00 +0200	[thread overview]
Message-ID: <cover.1602491752.git.tgolembi@redhat.com> (raw)

Adds command to list disks of the VM.

The patch does compile on master but to work properly it requires changes to
qemu-ga by Thomas Huth in series: Allow guest-get-fsinfo also for non-PCI
devices.

v4:
- 2/3: don't leak syspath in build_guest_fsinfo_for_device()
- 3/3:
  - added ERRP_GUARD
  - don't loop forever when qga fails to get device information details

v3:
- renamed "slaves" field to "dependents"
- comments from Marc and Daniel
- 2/3: factored out pieces of code into separate functions

v2:
- added new struct in API to handle the information
- split changes into several patches
- for Linux list also slaves, partitions and virtual disks so that the disk
  hierarchy is preserved
- fixed issues pointed out by Michael

Tomáš Golembiovský (3):
  qga: add command guest-get-disks
  qga: add implementation of guest-get-disks for Linux
  qga: add implementation of guest-get-disks for Windows

 qga/commands-posix.c | 290 ++++++++++++++++++++++++++++++++++++++++++-
 qga/commands-win32.c | 101 +++++++++++++++
 qga/qapi-schema.json |  31 +++++
 3 files changed, 417 insertions(+), 5 deletions(-)

-- 
2.28.0



             reply	other threads:[~2020-10-12  8:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-12  8:36 Tomáš Golembiovský [this message]
2020-10-12  8:36 ` [PATCH v4 1/3] qga: add command guest-get-disks Tomáš Golembiovský
2020-10-12  8:36 ` [PATCH v4 2/3] qga: add implementation of guest-get-disks for Linux Tomáš Golembiovský
2020-10-13  7:26   ` Marc-André Lureau
2020-10-14  9:34     ` Tomáš Golembiovský
2020-10-12  8:36 ` [PATCH v4 3/3] qga: add implementation of guest-get-disks for Windows Tomáš Golembiovský

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1602491752.git.tgolembi@redhat.com \
    --to=tgolembi@redhat.com \
    --cc=berrange@redhat.com \
    --cc=luoyonggang@gmail.com \
    --cc=marcandre.lureau@gmail.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).