From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Tao Xu <tao3.xu@intel.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: [PATCH v3 0/2] quorum: Implement bdrv_co_block_status()
Date: Wed, 11 Nov 2020 17:53:53 +0100 [thread overview]
Message-ID: <cover.1605111801.git.berto@igalia.com> (raw)
Hi,
I realized that if one of the children returns an error during
co_block_status() then we should not pass the error immediately to the
caller, because that's a situation that Quorum should be able to
handle.
The new version of the patch takes the simpler approach of falling
back to returning BDRV_BLOCK_DATA, as if Quorum did not implement
bdrv_co_block_status(). This will force the caller to try to read the
actual data and the normal Quorum voting and error handling process
will be used.
Berto
v3:
- Fall back to BDRV_BLOCK_DATA if a child returns an error.
v2: https://lists.gnu.org/archive/html/qemu-block/2020-11/msg00259.html
- Implement bdrv_co_pwrite_zeroes() for quorum
v1: https://lists.gnu.org/archive/html/qemu-block/2020-11/msg00163.html
Alberto Garcia (2):
quorum: Implement bdrv_co_block_status()
quorum: Implement bdrv_co_pwrite_zeroes()
block/quorum.c | 70 ++++++++++++++++-
tests/qemu-iotests/312 | 155 +++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/312.out | 71 +++++++++++++++++
tests/qemu-iotests/group | 1 +
4 files changed, 295 insertions(+), 2 deletions(-)
create mode 100755 tests/qemu-iotests/312
create mode 100644 tests/qemu-iotests/312.out
--
2.20.1
next reply other threads:[~2020-11-11 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 16:53 Alberto Garcia [this message]
2020-11-11 16:53 ` [PATCH v3 1/2] quorum: Implement bdrv_co_block_status() Alberto Garcia
2020-11-13 11:36 ` Max Reitz
2020-11-11 16:53 ` [PATCH v3 2/2] quorum: Implement bdrv_co_pwrite_zeroes() Alberto Garcia
2020-11-13 11:49 ` Max Reitz
2020-11-13 16:07 ` Alberto Garcia
2020-11-13 16:11 ` Max Reitz
2020-11-13 16:26 ` Alberto Garcia
2020-11-13 16:35 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1605111801.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=tao3.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).