From: Alberto Garcia <berto@igalia.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>,
Alberto Garcia <berto@igalia.com>,
qemu-block@nongnu.org, Kashyap Chamarthy <kchamart@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: [RFC PATCH 0/2] Allow changing bs->file on reopen
Date: Fri, 15 Jan 2021 14:02:36 +0100 [thread overview]
Message-ID: <cover.1610715661.git.berto@igalia.com> (raw)
Hi,
during the past months we talked about making x-blockdev-reopen stable
API, and one of the missing things was having support for changing
bs->file. See here for the discusssion (I can't find the message from
Kashyap that started the thread in the web archives):
https://lists.gnu.org/archive/html/qemu-block/2020-10/msg00922.html
I was testing this and one of the problems that I found was that
removing a filter node using this command is tricky because of the
permission system, see here for details:
https://lists.gnu.org/archive/html/qemu-block/2020-12/msg00092.html
The good news is that Vladimir posted a set of patches that changes
the way that permissions are updated on reopen:
https://lists.gnu.org/archive/html/qemu-block/2020-11/msg00745.html
I was testing if this would be useful to solve the problem that I
mentioned earlier and it seems to be the case so I wrote a patch to
add support for changing bs->file, along with a couple of test cases.
This is still an RFC but you can see the idea.
These patches apply on top of Vladimir's branch:
git: https://src.openvz.org/scm/~vsementsov/qemu.git
tag: up-block-topologic-perm-v2
Opinions are very welcome!
Berto
Alberto Garcia (2):
block: Allow changing bs->file on reopen
iotests: Update 245 to support replacing files with x-blockdev-reopen
include/block/block.h | 1 +
block.c | 61 ++++++++++++++++++++++++++++++++++++++
tests/qemu-iotests/245 | 61 +++++++++++++++++++++++++++++++++++---
tests/qemu-iotests/245.out | 4 +--
4 files changed, 121 insertions(+), 6 deletions(-)
--
2.20.1
next reply other threads:[~2021-01-15 13:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 13:02 Alberto Garcia [this message]
2021-01-15 13:02 ` [RFC PATCH 1/2] block: Allow changing bs->file on reopen Alberto Garcia
2021-01-18 10:15 ` Vladimir Sementsov-Ogievskiy
2021-01-19 11:46 ` Alberto Garcia
2021-01-15 13:02 ` [RFC PATCH 2/2] iotests: Update 245 to support replacing files with x-blockdev-reopen Alberto Garcia
2021-01-15 13:31 ` [RFC PATCH 0/2] Allow changing bs->file on reopen Kashyap Chamarthy
2021-01-18 10:22 ` Vladimir Sementsov-Ogievskiy
2021-01-20 13:51 ` Alberto Garcia
2021-01-20 13:55 ` Vladimir Sementsov-Ogievskiy
2021-01-21 10:52 ` Kevin Wolf
2021-02-05 12:47 ` Alberto Garcia
2021-02-05 15:41 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1610715661.git.berto@igalia.com \
--to=berto@igalia.com \
--cc=kchamart@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).