qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Lukas Straub <lukasstraub2@web.de>
To: qemu-devel <qemu-devel@nongnu.org>
Cc: Marc-Andre Lureau <marcandre.lureau@gmail.com>
Subject: [PATCH v8 0/4] yank: Add chardev tests and fixes
Date: Tue, 30 Mar 2021 20:13:13 +0200	[thread overview]
Message-ID: <cover.1617127849.git.lukasstraub2@web.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1784 bytes --]

Hello Everyone,
These patches increase test coverage for yank, add tests and fix bugs and
crashes in yank in combination with chardev-change.
Please Review.

Regards,
Lukas Straub

Changes:
-v8:
 -test: use custom thread to accept() instead of qio_net_listener

-v7:
 -test: fix patchew error by not using macros

-v6:
 -test: (hopefully) fix test on OSX by using qio_net_listener on the dummy
  server socket so new clients get accept()'ed properly

-v5:
 -test: fix memory leak

-v4:
 -test: fix CharChangeTestConfig structs on stack going out of scope
 -test: move after bugfixes

-v3:
 -Base on <cover.1616521341.git.lukasstraub2@web.de>
  ([PATCH 0/2] yank: Always link full yank code)
 -Drop patch 1 (tests: Use the normal yank code instead of stubs in relevant tests)

-v2:
 -test: add license
 -test: factorize testcases to a single function
 -test: test chardev_change with initialization of new chardev failing
 -fix chardev_change with initialization of new chardev failing
 -add reviewed-by and tested-by tags

Based-on: <cover.1616521341.git.lukasstraub2@web.de>
([PATCH 0/2] yank: Always link full yank code)


Lukas Straub (4):
  chardev/char.c: Move object_property_try_add_child out of chardev_new
  chardev/char.c: Always pass id to chardev_new
  chardev: Fix yank with the chardev-change case
  tests: Add tests for yank with the chardev-change case

 MAINTAINERS            |   1 +
 chardev/char-socket.c  |  20 +++-
 chardev/char.c         |  77 ++++++++-----
 include/chardev/char.h |   3 +
 tests/unit/meson.build |   3 +-
 tests/unit/test-yank.c | 249 +++++++++++++++++++++++++++++++++++++++++
 6 files changed, 324 insertions(+), 29 deletions(-)
 create mode 100644 tests/unit/test-yank.c

--
2.30.2

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

             reply	other threads:[~2021-03-30 18:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-30 18:13 Lukas Straub [this message]
2021-03-30 18:13 ` [PATCH v8 1/4] chardev/char.c: Move object_property_try_add_child out of chardev_new Lukas Straub
2021-03-30 18:13 ` [PATCH v8 2/4] chardev/char.c: Always pass id to chardev_new Lukas Straub
2021-03-30 18:13 ` [PATCH v8 3/4] chardev: Fix yank with the chardev-change case Lukas Straub
2021-03-30 18:13 ` [PATCH v8 4/4] tests: Add tests for " Lukas Straub

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1617127849.git.lukasstraub2@web.de \
    --to=lukasstraub2@web.de \
    --cc=marcandre.lureau@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).