qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: [PATCH v2 0/7] 9pfs: Twalk optimization
Date: Fri, 4 Jun 2021 17:48:49 +0200	[thread overview]
Message-ID: <cover.1622821729.git.qemu_oss@crudebyte.com> (raw)

This patch set reduces latency of Twalk handling by reducing the amount of
thread hops, similar to previous Treaddir optimization.

The performance gain of this patch set is not as spectacular as previously
with Treaddir, but there is definitely a measurable difference.

The actualy performance optimization is patch 7. With the benchmark of
patch 2, the runtime of the Twalk test was cut in half. In real world tests
I measured a performance gain (i.e. running an entire guest OS, and hence
mixed with all other kinds of 9p requests) of about 2%, again measured in a
mix, not concentrated on Twalk alone.

v1 -> v2:

  * Added a separate [NEW PATCH 1] for fixing not_same_qid() semantic.

  * Code style: use sizeof(var-name) instead of sizeof(type-name)
    [PATCH 3].

  * Split out dropping fid_to_qid() into separate [PATCH 4].

  * Split out replacing not_same_qid() by same_stat_id() into separate
    [PATCH 5].

  * Split out dropping root_qid into separate [PATCH 6].

Christian Schoenebeck (7):
  9pfs: fix not_same_qid()
  9pfs: Twalk benchmark
  9pfs: capture root stat
  9pfs: drop fid_to_qid()
  9pfs: replace not_same_qid() by same_stat_id()
  9pfs: drop root_qid
  9pfs: reduce latency of Twalk

 hw/9pfs/9p.c                 | 128 +++++++++++++++++++++++------------
 hw/9pfs/9p.h                 |   2 +-
 tests/qtest/virtio-9p-test.c |  30 ++++++++
 3 files changed, 116 insertions(+), 44 deletions(-)

-- 
2.20.1



             reply	other threads:[~2021-06-04 17:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 15:48 Christian Schoenebeck [this message]
2021-05-27 17:03 ` [PATCH v2 2/7] 9pfs: Twalk benchmark Christian Schoenebeck
2021-05-27 17:04 ` [PATCH v2 3/7] 9pfs: capture root stat Christian Schoenebeck
2021-06-04 14:46 ` [PATCH v2 1/7] 9pfs: fix not_same_qid() Christian Schoenebeck
2021-06-04 15:13 ` [PATCH v2 4/7] 9pfs: drop fid_to_qid() Christian Schoenebeck
2021-06-04 15:21 ` [PATCH v2 5/7] 9pfs: replace not_same_qid() by same_stat_id() Christian Schoenebeck
2021-06-04 15:32 ` [PATCH v2 6/7] 9pfs: drop root_qid Christian Schoenebeck
2021-06-04 15:38 ` [PATCH v2 7/7] 9pfs: reduce latency of Twalk Christian Schoenebeck
2021-07-02 14:36   ` Greg Kurz
2021-07-02 15:05     ` Christian Schoenebeck
2021-07-02 15:26       ` Greg Kurz
2021-06-04 16:31 ` [PATCH v2 0/7] 9pfs: Twalk optimization Greg Kurz
2021-06-04 18:23   ` Christian Schoenebeck
2021-06-28 10:20     ` Christian Schoenebeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1622821729.git.qemu_oss@crudebyte.com \
    --to=qemu_oss@crudebyte.com \
    --cc=groug@kaod.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).