From: Liren Wei <lrwei@bupt.edu.cn>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, richard.henderson@linaro.org
Subject: [PATCH 0/2] Fix defect in TranslationBlock insertion procedure
Date: Sun, 4 Jul 2021 22:31:25 +0800 [thread overview]
Message-ID: <cover.1625404483.git.lrwei@bupt.edu.cn> (raw)
TranslationBlocks are now inserted first into QHT and then into its
corresponding tcg_region_tree. This is problematic under MTTCG, as
other vCPU threads may immediately execute it, and even bailout before
the TB itself is inserted into its tcg_region_tree, resulting in an
incorrect CPUState after rewinding.
Liren Wei (2):
accel/tcg: Hoist tcg_tb_insert() up above tb_link_page()
tcg: Bake tb_destroy() into tcg_region_tree
accel/tcg/translate-all.c | 15 ++++++++-------
include/tcg/tcg.h | 1 -
tcg/region.c | 18 +++++++-----------
3 files changed, 15 insertions(+), 19 deletions(-)
--
2.32.0
next reply other threads:[~2021-07-04 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 14:31 Liren Wei [this message]
2021-07-04 14:31 ` [PATCH 1/2] accel/tcg: Hoist tcg_tb_insert() up above tb_link_page() Liren Wei
2021-07-07 0:12 ` Richard Henderson
2021-07-04 14:31 ` [PATCH 2/2] tcg: Bake tb_destroy() into tcg_region_tree Liren Wei
2021-07-07 0:34 ` Richard Henderson
2021-07-07 3:14 ` Liren Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1625404483.git.lrwei@bupt.edu.cn \
--to=lrwei@bupt.edu.cn \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).