From: Tom Lendacky <thomas.lendacky@amd.com>
To: <qemu-devel@nongnu.org>, <kvm@vger.kernel.org>
Cc: "Eric Blake" <eblake@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Michael Roth" <michael.roth@amd.com>
Subject: [PATCH 0/4] Qemu SEV reduced-phys-bits fixes
Date: Fri, 30 Sep 2022 10:14:26 -0500 [thread overview]
Message-ID: <cover.1664550870.git.thomas.lendacky@amd.com> (raw)
This patch series fixes up and tries to remove some confusion around the
SEV reduced-phys-bits parameter.
Based on the "AMD64 Architecture Programmer's Manual Volume 2: System
Programming", section "15.34.6 Page Table Support" [1], a guest should
only ever see a maximum of 1 bit of physical address space reduction.
- Update the documentation, to change the default value from 5 to 1.
- Update the validation of the parameter to ensure the parameter value
is within the range of the CPUID field that it is reported in. To allow
for backwards compatibility, especially to support the previously
documented value of 5, allow the full range of values from 1 to 63
(0 was never allowed).
- Update the setting of CPUID 0x8000001F_EBX to limit the values to the
field width that they are setting as an additional safeguard.
[1] https://www.amd.com/system/files/TechDocs/24593.pdf
Tom Lendacky (4):
qapi, i386/sev: Change the reduced-phys-bits value from 5 to 1
qemu-options.hx: Update the reduced-phys-bits documentation
i386/sev: Update checks and information related to reduced-phys-bits
i386/cpu: Update how the EBX register of CPUID 0x8000001F is set
qapi/misc-target.json | 2 +-
qemu-options.hx | 4 ++--
target/i386/cpu.c | 4 ++--
target/i386/sev.c | 17 ++++++++++++++---
4 files changed, 19 insertions(+), 8 deletions(-)
--
2.37.3
next reply other threads:[~2022-09-30 15:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 15:14 Tom Lendacky [this message]
2022-09-30 15:14 ` [PATCH 1/4] qapi, i386/sev: Change the reduced-phys-bits value from 5 to 1 Tom Lendacky
2022-10-13 13:22 ` Dr. David Alan Gilbert
2022-09-30 15:14 ` [PATCH 2/4] qemu-options.hx: Update the reduced-phys-bits documentation Tom Lendacky
2022-10-13 13:29 ` Dr. David Alan Gilbert
2022-09-30 15:14 ` [PATCH 3/4] i386/sev: Update checks and information related to reduced-phys-bits Tom Lendacky
2022-10-13 13:31 ` Dr. David Alan Gilbert
2022-09-30 15:14 ` [PATCH 4/4] i386/cpu: Update how the EBX register of CPUID 0x8000001F is set Tom Lendacky
2022-10-13 14:01 ` Dr. David Alan Gilbert
2023-01-04 18:13 ` [PATCH 0/4] Qemu SEV reduced-phys-bits fixes Tom Lendacky
2023-01-09 15:05 ` Daniel P. Berrangé
2023-04-21 8:48 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1664550870.git.thomas.lendacky@amd.com \
--to=thomas.lendacky@amd.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=f4bug@amsat.org \
--cc=kvm@vger.kernel.org \
--cc=michael.roth@amd.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).