From: Daniel Xu <dxu@dxuuu.xyz>
To: qemu-devel@nongnu.org
Cc: marcandre.lureau@gmail.com
Subject: [PATCH v2 0/3] qga: Add optional `merge-output` flag to guest-exec QAPI
Date: Tue, 28 Feb 2023 11:50:33 -0700 [thread overview]
Message-ID: <cover.1677609866.git.dxu@dxuuu.xyz> (raw)
Currently, the captured output (via `capture-output`) is segregated into
separate GuestExecStatus fields (`out-data` and `err-data`). This means
that downstream consumers have no way to reassemble the captured data
back into the original stream.
This is relevant for chatty and semi-interactive (ie. read only) CLI
tools. Such tools may deliberately interleave stdout and stderr for
visual effect. If segregated, the output becomes harder to visually
understand.
This patchset adds support for merging stderr and stdout output streams
via a new QAPI flag.
Changes from v1:
* Drop invalid test fix
* Do not support `merge-output` on windows guests
* Fix a UAF in tests
Daniel Xu (3):
crypto/luks: Initialize stack variable to silence warning
qga: Add optional `merge-output` flag to guest-exec qapi
qga: test: Add tests for `merge-output` flag
crypto/block-luks.c | 2 +-
qga/commands.c | 14 ++++-
qga/qapi-schema.json | 6 +-
tests/unit/test-qga.c | 133 ++++++++++++++++++++++++++++++++++++------
4 files changed, 134 insertions(+), 21 deletions(-)
--
2.39.1
next reply other threads:[~2023-02-28 18:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-28 18:50 Daniel Xu [this message]
2023-02-28 18:50 ` [PATCH v2 1/3] crypto/luks: Initialize stack variable to silence warning Daniel Xu
2023-02-28 18:50 ` [PATCH v2 2/3] qga: Add optional `merge-output` flag to guest-exec qapi Daniel Xu
2023-02-28 19:26 ` Marc-André Lureau
2023-02-28 20:31 ` Daniel Xu
2023-02-28 18:50 ` [PATCH v2 3/3] qga: test: Add tests for `merge-output` flag Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1677609866.git.dxu@dxuuu.xyz \
--to=dxu@dxuuu.xyz \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).