From: Chuck Zmudzinski <brchuckz@aol.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
Artyom Tarasenko <atar4qemu@gmail.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
Paul Durrant <paul@xen.org>,
xen-devel@lists.xenproject.org
Subject: [PATCH v4 0/2] pci: slot_reserved_mask improvements
Date: Wed, 15 Mar 2023 10:26:18 -0400 [thread overview]
Message-ID: <cover.1678888385.git.brchuckz@aol.com> (raw)
In-Reply-To: cover.1678888385.git.brchuckz.ref@aol.com
This patch series consists of two patches. The first provides accessor
functions in pci.h to avoid direct access of slot_reserved_mask
according to the comment at the top of include/hw/pci/pci_bus.h. No
functional change is intended with this patch.
The second patch replaces slot_reserved_mask with two new masks,
slot_reserved_auto_mask and slot_reserved_manual_mask so the current
behavior of reserving slot 2 for the Intel IGD for the xenfv machine
will be ignored if an administrator manually configures a device to use
the reserved slot.
The current behavior of always reserving slots in the sun4u machine is
preserved by this patch series; the patch series only changes how
slot_reserved_mask works in the xenfv machine. Although the patch
series can affect xenfv machines configured for igd-passthru if an
administrator assigns some of the pci slot addresses manually, it
does not affect the libxl default configuration for igd-passthru because
libxl uses automatic slot assignment by default.
Testing:
- Tested xenfv/igd with both manual and auto slot allocation - behaves as expected
- Verified that qemu-system-sparc64 still compiles with the patches to sun4u.c
- xen4u machine not tested -- Mark, can you do this?
Link: https://lore.kernel.org/qemu-devel/20230106064838-mutt-send-email-mst@kernel.org/
Chuck Zmudzinski (2):
pci: avoid accessing slot_reserved_mask directly outside of pci.c
pci: introduce slot_reserved_auto_mask and slot_reserved_manual_mask
Changelog
v4: I forgot to check the patches in v3 for style corrections (sorry about
that), and the second patch had three lines that were too long. Other
than correcting the style problems, no changes since v3.
v3: Re-work second patch in response to comments/discussion of v2
v2: Add first patch and cover letter to make this a 2-patch series
Make changes to the second patch (see second patch for changelog)
hw/pci/pci.c | 33 ++++++++++++++++++++++++++++-----
hw/sparc64/sun4u.c | 7 +++----
hw/xen/xen_pt.c | 8 ++++----
include/hw/pci/pci.h | 3 +++
include/hw/pci/pci_bus.h | 3 ++-
5 files changed, 40 insertions(+), 14 deletions(-)
--
2.39.2
next parent reply other threads:[~2023-03-15 14:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1678888385.git.brchuckz.ref@aol.com>
2023-03-15 14:26 ` Chuck Zmudzinski [this message]
2023-03-15 14:26 ` [PATCH v4 1/2] pci: avoid accessing slot_reserved_mask directly outside of pci.c Chuck Zmudzinski
2023-03-15 14:26 ` [PATCH v4 2/2] pci: introduce slot_reserved_auto_mask and slot_reserved_manual_mask Chuck Zmudzinski
2023-03-23 10:18 ` [PATCH v4 0/2] pci: slot_reserved_mask improvements Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1678888385.git.brchuckz@aol.com \
--to=brchuckz@aol.com \
--cc=anthony.perard@citrix.com \
--cc=atar4qemu@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).