qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Hawkins Jiawei <yin31149@gmail.com>
To: jasowang@redhat.com, mst@redhat.com, eperezma@redhat.com
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org,
	yin31149@gmail.com, 18801353760@163.com
Subject: [PATCH RFC 0/1] Return -EINVAL if device's ack is VIRTIO_NET_ERR
Date: Wed, 14 Jun 2023 21:01:46 +0800	[thread overview]
Message-ID: <cover.1686746406.git.yin31149@gmail.com> (raw)

This patch fixes the problem that vhost_net_start_one() doesn't cancel
the device startup and returns 0 even if the device's ack is VIRTIO_NET_ERR
in net->nc->info->load().

Note that this problem also exists in
patch "vdpa: Add vhost_vdpa_net_load_offloads()" at [1].
Because this patch has not been merged yet, so I will submit the v2 patch
to fix the problem in that patch once the pending patch
has been successfully merged.

[1]. https://lists.nongnu.org/archive/html/qemu-devel/2023-06/msg00504.html

Hawkins Jiawei (1):
  vdpa: Return -EINVAL if device's ack is VIRTIO_NET_ERR

 net/vhost-vdpa.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

-- 
2.25.1



             reply	other threads:[~2023-06-14 13:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-14 13:01 Hawkins Jiawei [this message]
2023-06-14 13:01 ` [PATCH RFC 1/1] vdpa: Return -EINVAL if device's ack is VIRTIO_NET_ERR Hawkins Jiawei
2023-07-03 16:38   ` Eugenio Perez Martin
2023-07-04  1:28     ` Hawkins Jiawei
2023-07-03 16:52   ` Michael S. Tsirkin
2023-07-04  1:33     ` Hawkins Jiawei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1686746406.git.yin31149@gmail.com \
    --to=yin31149@gmail.com \
    --cc=18801353760@163.com \
    --cc=eperezma@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).