From: BALATON Zoltan <balaton@eik.bme.hu>
To: qemu-devel@nongnu.org
Cc: philmd@linaro.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Bernhard Beschow <shentey@gmail.com>,
vr_qemu@t-online.de
Subject: [PATCH v2 0/4] Fix IRQ routing in via south bridge
Date: Sun, 29 Oct 2023 12:07:31 +0100 (CET) [thread overview]
Message-ID: <cover.1698577151.git.balaton@eik.bme.hu> (raw)
Changes in v2:
- Avoid a potential problem noticed by Volker before with not clearing
interrupts when mapping is changed (may not happen in practice but we
can handle it here) also add some comments explaining how it works.
- Update some commit messages
This is going back to my otiginal proposal in
https://patchew.org/QEMU/cover.1677004414.git.balaton@eik.bme.hu/
implementing routing of interrupts from device functions and PCI
devices to ISA interrupts. On pegasos2 the firmware sets evertyhing to
share IRQ 9 so the current simpified version worked for taht but with
the amigaone machine its firmware makes use of this feature and
assigns different interrupts to functions and PCI devices so we need
to properly impelent this. Since any ISA interrupt can be controlled
by any interrupt source (different functions of the multifunction
device plus the 4 input pins from PCI devices) there are more than 4
possible sources so this can't be handled by just the 4 PCI interrupt
lines. We need to keep track of the state of each interrupt source to
be able to determine the level of the ISA interrupt and avoid one
device clearing it while other still has an interrupt.
This fixes USB on amigaone and maybe other bugs not discovered yet.
Regards,
BALATON Zoltan
BALATON Zoltan (4):
hw/isa/vt82c686: Bring back via_isa_set_irq()
hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts
hw/isa/vt82c686: Route PIRQ inputs using via_isa_set_irq()
hw/audio/via-ac97: Route interrupts using via_isa_set_irq()
hw/audio/via-ac97.c | 8 ++--
hw/isa/vt82c686.c | 75 +++++++++++++++++++++++++-------------
hw/usb/vt82c686-uhci-pci.c | 9 +++++
include/hw/isa/vt82c686.h | 2 +
4 files changed, 64 insertions(+), 30 deletions(-)
--
2.30.9
next reply other threads:[~2023-10-29 11:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 11:07 BALATON Zoltan [this message]
2023-10-29 11:07 ` [PATCH v2 1/4] hw/isa/vt82c686: Bring back via_isa_set_irq() BALATON Zoltan
2023-10-29 11:39 ` BALATON Zoltan
2023-10-29 11:07 ` [PATCH v2 2/4] hw/usb/vt82c686-uhci-pci: Use ISA instead of PCI interrupts BALATON Zoltan
2023-10-29 11:07 ` [PATCH v2 3/4] hw/isa/vt82c686: Route PIRQ inputs using via_isa_set_irq() BALATON Zoltan
2023-10-29 11:07 ` [PATCH v2 4/4] hw/audio/via-ac97: Route interrupts " BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1698577151.git.balaton@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=jiaxun.yang@flygoat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
--cc=vr_qemu@t-online.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).