qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
To: qemu-devel@nongnu.org, qemu-stable@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	"Zheyu Ma" <zheyuma97@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v1 0/4] virtio_snd_set_config: Fix #2296
Date: Mon, 22 Apr 2024 15:52:10 +0300	[thread overview]
Message-ID: <cover.1713789200.git.manos.pitsidianakis@linaro.org> (raw)

Changing the number of streams via virtio_snd_set_config() did not
re-configure the audio card, leaving it in an invalid state.

Reported in https://gitlab.com/qemu-project/qemu/-/issues/2296

Manos Pitsidianakis (4):
  virtio-snd: add virtio_snd_is_config_valid()
  virtio-snd: factor card setup out of realize func
  virtio-snd: factor card removal out of unrealize()
  virtio_snd_set_config: validate and re-setup card

 hw/audio/virtio-snd.c | 174 +++++++++++++++++++++++++-----------------
 1 file changed, 105 insertions(+), 69 deletions(-)


base-commit: 62dbe54c24dbf77051bafe1039c31ddc8f37602d
-- 
γαῖα πυρί μιχθήτω



             reply	other threads:[~2024-04-22 12:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-22 12:52 Manos Pitsidianakis [this message]
2024-04-22 12:52 ` [PATCH v1 1/4] virtio-snd: add virtio_snd_is_config_valid() Manos Pitsidianakis
2024-04-22 13:20   ` Philippe Mathieu-Daudé
2024-04-22 12:52 ` [PATCH v1 2/4] virtio-snd: factor card setup out of realize func Manos Pitsidianakis
2024-04-22 13:23   ` Philippe Mathieu-Daudé
2024-04-22 12:52 ` [PATCH v1 3/4] virtio-snd: factor card removal out of unrealize() Manos Pitsidianakis
2024-04-22 13:27   ` Philippe Mathieu-Daudé
2024-04-23  8:17     ` Philippe Mathieu-Daudé
2024-04-22 12:52 ` [PATCH v1 4/4] virtio_snd_set_config: validate and re-setup card Manos Pitsidianakis
2024-09-01 13:25 ` [PATCH v1 0/4] virtio_snd_set_config: Fix #2296 Volker Rümelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1713789200.git.manos.pitsidianakis@linaro.org \
    --to=manos.pitsidianakis@linaro.org \
    --cc=kraxel@redhat.com \
    --cc=mst@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=zheyuma97@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).