From: Omar Sandoval <osandov@osandov.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Thomas Huth <thuth@redhat.com>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
linux-debuggers@vger.kernel.org
Subject: [PATCH 0/2] arch_dump: fix prstatus pid on s390x and ppc
Date: Tue, 18 Jun 2024 22:00:11 -0700 [thread overview]
Message-ID: <cover.1718771802.git.osandov@osandov.com> (raw)
Hello,
I maintain drgn [1], a debugger for the Linux kernel. I ran into a quirk
of the NT_PRSTATUS note in kernel core dumps [2], so I looked into how
QEMU's dump-guest-memory command generates NT_PRSTATUS. I noticed that
on most architectures, the note's PID field is set to the CPU ID plus 1.
There are two exceptions: on s390x, there's an endianness bug (it's not
byte swapped if the host is little endian), and on ppc, it's not set at
all (it defaults to zero). They're both easy fixes.
Thanks,
Omar
1: https://github.com/osandov/drgn
2: https://github.com/osandov/drgn/issues/404
Omar Sandoval (2):
target/s390x/arch_dump: use correct byte order for pid
target/ppc/arch_dump: set prstatus pid to cpuid
target/ppc/arch_dump.c | 21 ++++++++++++---------
target/s390x/arch_dump.c | 2 +-
2 files changed, 13 insertions(+), 10 deletions(-)
--
2.45.2
next reply other threads:[~2024-06-19 5:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 5:00 Omar Sandoval [this message]
2024-06-19 5:00 ` [PATCH 1/2] target/s390x/arch_dump: use correct byte order for pid Omar Sandoval
2024-06-19 5:57 ` Thomas Huth
2024-06-19 5:00 ` [PATCH 2/2] target/ppc/arch_dump: set prstatus pid to cpuid Omar Sandoval
2024-06-19 6:01 ` Thomas Huth
2024-06-24 7:22 ` Harsh Prateek Bora
2024-06-24 6:17 ` [PATCH 0/2] arch_dump: fix prstatus pid on s390x and ppc Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1718771802.git.osandov@osandov.com \
--to=osandov@osandov.com \
--cc=danielhb413@gmail.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=linux-debuggers@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).