From: Roy Hopkins <roy.hopkins@suse.com>
To: qemu-devel@nongnu.org
Cc: "Roy Hopkins" <roy.hopkins@suse.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Marcelo Tosatti" <mtosatti@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
"Cornelia Huck" <cohuck@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Sergio Lopez" <slp@redhat.com>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Alistair Francis" <alistair@alistair23.me>,
"Peter Xu" <peterx@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Tom Lendacky" <thomas.lendacky@amd.com>,
"Michael Roth" <michael.roth@amd.com>,
"Ani Sinha" <anisinha@redhat.com>,
"Jörg Roedel" <jroedel@suse.com>
Subject: [PATCH v6 00/16] Introduce support for IGVM files
Date: Thu, 26 Sep 2024 12:41:49 +0100 [thread overview]
Message-ID: <cover.1727341768.git.roy.hopkins@suse.com> (raw)
Here is v6 of the set of patches to add support for IGVM files to QEMU. This is
based on commit a5dd9ee060 of qemu.
This version addresses all of the review comments from v5 [1]. As always, thanks
to those that have been following along, reviewing and testing this series. This
v6 patch series is also available on github: [2]
For testing IGVM support in QEMU you need to generate an IGVM file that is
configured for the platform you want to launch. You can use the `buildigvm`
test tool [3] to allow generation of IGVM files for all currently supported
platforms. Patch 11/17 contains information on how to generate an IGVM file
using this tool.
Changes in v6:
Based on Stefano's review:
* Change ConfidentialGuestSupport check_support() function to return a bool and
add documentation.
* Ensure igvm_free() is called after successful or failed processing of igvm
file.
* Add command-line documentation for which machine types support IGVM.
* Update target version from 9.1 to 9.2.
* Add Acked-by and Reviewed-by to relevant commits.
Patch summary:
1-11: Add support and documentation for processing IGVM files for SEV, SEV-ES,
SEV-SNP and native platforms.
12-15: Processing of policy and SEV-SNP ID_BLOCK from IGVM file.
16: Add pre-processing of IGVM file to support synchronization of 'SEV_FEATURES'
from IGVM VMSA to KVM.
[1] Link to v5:
https://lore.kernel.org/all/cover.1723560001.git.roy.hopkins@suse.com/
[2] v6 patches also available here:
https://github.com/roy-hopkins/qemu/tree/igvm_master_v6
[3] `buildigvm` tool v0.2.0
https://github.com/roy-hopkins/buildigvm/releases/tag/v0.2.0
Roy Hopkins (16):
meson: Add optional dependency on IGVM library
backends/confidential-guest-support: Add functions to support IGVM
backends/igvm: Add IGVM loader and configuration
hw/i386: Add igvm-cfg object and processing for IGVM files
i386/pc_sysfw: Ensure sysfw flash configuration does not conflict with
IGVM
sev: Update launch_update_data functions to use Error handling
target/i386: Allow setting of R_LDTR and R_TR with
cpu_x86_load_seg_cache()
i386/sev: Refactor setting of reset vector and initial CPU state
i386/sev: Implement ConfidentialGuestSupport functions for SEV
docs/system: Add documentation on support for IGVM
docs/interop/firmware.json: Add igvm to FirmwareDevice
backends/confidential-guest-support: Add set_guest_policy() function
backends/igvm: Process initialization sections in IGVM file
backends/igvm: Handle policy for SEV guests
i386/sev: Add implementation of CGS set_guest_policy()
sev: Provide sev_features flags from IGVM VMSA to KVM_SEV_INIT2
backends/confidential-guest-support.c | 43 +
backends/igvm-cfg.c | 52 ++
backends/igvm.c | 967 +++++++++++++++++++++
backends/igvm.h | 23 +
backends/meson.build | 5 +
docs/interop/firmware.json | 30 +-
docs/system/i386/amd-memory-encryption.rst | 2 +
docs/system/igvm.rst | 173 ++++
docs/system/index.rst | 1 +
hw/i386/pc.c | 12 +
hw/i386/pc_piix.c | 10 +
hw/i386/pc_q35.c | 10 +
hw/i386/pc_sysfw.c | 31 +-
include/exec/confidential-guest-support.h | 88 ++
include/hw/i386/x86.h | 3 +
include/sysemu/igvm-cfg.h | 47 +
meson.build | 8 +
meson_options.txt | 2 +
qapi/qom.json | 17 +
qemu-options.hx | 28 +
scripts/meson-buildoptions.sh | 3 +
target/i386/cpu.h | 9 +-
target/i386/sev.c | 850 ++++++++++++++++--
target/i386/sev.h | 124 +++
24 files changed, 2454 insertions(+), 84 deletions(-)
create mode 100644 backends/igvm-cfg.c
create mode 100644 backends/igvm.c
create mode 100644 backends/igvm.h
create mode 100644 docs/system/igvm.rst
create mode 100644 include/sysemu/igvm-cfg.h
--
2.43.0
next reply other threads:[~2024-09-26 11:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 11:41 Roy Hopkins [this message]
2024-09-26 11:41 ` [PATCH v6 01/16] meson: Add optional dependency on IGVM library Roy Hopkins
2024-09-26 11:41 ` [PATCH v6 02/16] backends/confidential-guest-support: Add functions to support IGVM Roy Hopkins
2024-09-26 11:41 ` [PATCH v6 03/16] backends/igvm: Add IGVM loader and configuration Roy Hopkins
2024-09-26 11:41 ` [PATCH v6 04/16] hw/i386: Add igvm-cfg object and processing for IGVM files Roy Hopkins
2024-10-01 9:53 ` Stefano Garzarella
2024-10-22 9:04 ` Stefano Garzarella
2024-09-26 11:41 ` [PATCH v6 05/16] i386/pc_sysfw: Ensure sysfw flash configuration does not conflict with IGVM Roy Hopkins
2024-10-07 18:53 ` Gupta, Pankaj
2024-09-26 11:41 ` [PATCH v6 06/16] sev: Update launch_update_data functions to use Error handling Roy Hopkins
2024-09-26 11:41 ` [PATCH v6 07/16] target/i386: Allow setting of R_LDTR and R_TR with cpu_x86_load_seg_cache() Roy Hopkins
2024-09-26 11:41 ` [PATCH v6 08/16] i386/sev: Refactor setting of reset vector and initial CPU state Roy Hopkins
2024-09-26 11:41 ` [PATCH v6 09/16] i386/sev: Implement ConfidentialGuestSupport functions for SEV Roy Hopkins
2024-09-26 11:41 ` [PATCH v6 10/16] docs/system: Add documentation on support for IGVM Roy Hopkins
2024-09-26 11:42 ` [PATCH v6 11/16] docs/interop/firmware.json: Add igvm to FirmwareDevice Roy Hopkins
2024-09-26 11:42 ` [PATCH v6 12/16] backends/confidential-guest-support: Add set_guest_policy() function Roy Hopkins
2024-09-26 11:42 ` [PATCH v6 13/16] backends/igvm: Process initialization sections in IGVM file Roy Hopkins
2024-09-26 11:42 ` [PATCH v6 14/16] backends/igvm: Handle policy for SEV guests Roy Hopkins
2024-09-26 11:42 ` [PATCH v6 15/16] i386/sev: Add implementation of CGS set_guest_policy() Roy Hopkins
2024-09-26 11:42 ` [PATCH v6 16/16] sev: Provide sev_features flags from IGVM VMSA to KVM_SEV_INIT2 Roy Hopkins
2024-10-21 14:44 ` [PATCH v6 00/16] Introduce support for IGVM files Roy Hopkins
2024-10-22 9:05 ` Stefano Garzarella
2024-10-22 11:31 ` Roy Hopkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1727341768.git.roy.hopkins@suse.com \
--to=roy.hopkins@suse.com \
--cc=alistair@alistair23.me \
--cc=anisinha@redhat.com \
--cc=berrange@redhat.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=eduardo@habkost.net \
--cc=imammedo@redhat.com \
--cc=jroedel@suse.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=michael.roth@amd.com \
--cc=mst@redhat.com \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=slp@redhat.com \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).