From: BALATON Zoltan <balaton@eik.bme.hu>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, philmd@linaro.org
Subject: [PATCH v2 0/2] Separate memory access logs from guest_errors
Date: Sat, 02 Nov 2024 13:17:34 +0100 (CET) [thread overview]
Message-ID: <cover.1730549443.git.balaton@eik.bme.hu> (raw)
Originally memory access logs were a debug define that then were
converted to log messages but were classified as guest_errors which
already logs misc errors. As invalid memory access logs can come from
accessing not emulated peripherals or memory areas, these often
generate a lot of messages that are better be controlled separately
from other errors to avoid obscuring those. As an example try
'qemu-system-ppc -d guest_errors' to see the problem. After this
series the actual guest error logs are easier to spot. I've tried to
submit this before but there were some people who liked the current
behaviour so now this series has another patch that preserves the old
option printing a warning to allow time to get used to the new
behaviour (which actually brings back the old behaviour when mem
access logs were a debug define). This second patch is optional if
changing the behaviour without notice is acceptable. As these are
debug switches no deprecation period is needed so the second patch
could be omitted. I leave that decision to the maintainers.
v2: Rename the option from memaccess to invalid_mem as suggested by
Peter Maydell
Regards,
BALATON Zoltan
BALATON Zoltan (2):
log: Add separate debug option for logging invalid memory accesses
log: Suggest using -d guest_error,invalid_mem instead of guest_errors
docs/devel/secure-coding-practices.rst | 2 +-
include/qemu/log.h | 1 +
system/memory.c | 6 +++---
system/physmem.c | 2 +-
tests/avocado/smmu.py | 2 +-
tests/qtest/pnv-host-i2c-test.c | 2 +-
util/log.c | 8 +++++++-
7 files changed, 15 insertions(+), 8 deletions(-)
--
2.30.9
next reply other threads:[~2024-11-02 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-02 12:17 BALATON Zoltan [this message]
2024-11-02 12:17 ` [PATCH v2 1/2] log: Add separate debug option for logging invalid memory accesses BALATON Zoltan
2024-12-17 16:01 ` Peter Maydell
2024-11-02 12:17 ` [PATCH v2 2/2] log: Suggest using -d guest_error, invalid_mem instead of guest_errors BALATON Zoltan
2024-12-13 12:41 ` [PATCH v2 0/2] Separate memory access logs from guest_errors BALATON Zoltan
2024-12-17 16:04 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1730549443.git.balaton@eik.bme.hu \
--to=balaton@eik.bme.hu \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).