From: David Edmondson <dme@dme.org>
To: Max Reitz <mreitz@redhat.com>
Cc: David Edmondson <david.edmondson@oracle.com>,
Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [PATCH v2 2/2] tests: Collapse echoed JSON input to a single line
Date: Wed, 06 Jan 2021 17:20:42 +0000 [thread overview]
Message-ID: <cuno8i2j82d.fsf@dme.org> (raw)
In-Reply-To: <b69093d7-359c-77e4-201a-29a1948796fd@redhat.com> (Max Reitz's message of "Wed, 6 Jan 2021 10:49:06 +0100")
On Wednesday, 2021-01-06 at 10:49:06 +01, Max Reitz wrote:
> On 21.12.20 14:49, David Edmondson wrote:
>> When sending JSON to running qemu, qemu-io, etc. instances, flatten
>> the echoed input to a single line to ensure that comparisons with the
>> expected input (which is always a single line) are successful.
>> Signed-off-by: David Edmondson <david.edmondson@oracle.com>
>> ---
>> tests/qemu-iotests/common.filter | 6 ++++++
>> tests/qemu-iotests/common.qemu | 2 +-
>> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> I think this is superseded now by commit 0e72078128229bf9efb54.
Yes, agreed.
dme.
--
Here I am, a rabbit-hearted girl.
prev parent reply other threads:[~2021-01-06 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-21 13:49 [PATCH v2 0/2] block: report errno when flock fcntl fails David Edmondson
2020-12-21 13:49 ` [PATCH v2 1/2] " David Edmondson
2020-12-22 14:31 ` Philippe Mathieu-Daudé
2021-01-06 9:48 ` Max Reitz
2021-01-06 11:58 ` David Edmondson
2020-12-21 13:49 ` [PATCH v2 2/2] tests: Collapse echoed JSON input to a single line David Edmondson
2021-01-06 9:49 ` Max Reitz
2021-01-06 17:20 ` David Edmondson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cuno8i2j82d.fsf@dme.org \
--to=dme@dme.org \
--cc=david.edmondson@oracle.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).