From: Richard Henderson <richard.henderson@linaro.org>
To: Warner Losh <imp@bsdimp.com>, qemu-devel@nongnu.org
Cc: arrowd@freebsd.org, def@freebsd.org, jrtc27@FreeBSD.org,
Kyle Evans <kevans@freebsd.org>
Subject: Re: [PATCH 3/6] bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate
Date: Tue, 7 Jun 2022 14:34:53 -0700 [thread overview]
Message-ID: <d00133d6-4c1f-637e-6a36-a68558bbefb0@linaro.org> (raw)
In-Reply-To: <20220607201440.41464-4-imp@bsdimp.com>
On 6/7/22 13:14, Warner Losh wrote:
> +static abi_long freebsd_syscall(void *cpu_env, int num, abi_long arg1,
> + abi_long arg2, abi_long arg3, abi_long arg4,
> + abi_long arg5, abi_long arg6, abi_long arg7,
> + abi_long arg8)
> +{
> + abi_long ret;
> +
> + switch (num) {
> + default:
> + gemu_log("qemu: unsupported syscall: %d\n", num);
qemu_log_mask(LOG_UNIMP, "Unsupported syscall: %d\n", num);
> +#ifdef DEBUG
> + gemu_log("freebsd syscall %d\n", num);
> +#endif
Drop this. It's redundant with strace.
Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-06-07 22:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 20:14 [PATCH 0/6] bsd-user upstreaming: read, write and exit Warner Losh
2022-06-07 20:14 ` [PATCH 1/6] bsd-user/freebsd/os-syscall.c: lock_iovec Warner Losh
2022-06-07 21:01 ` Richard Henderson
2022-06-07 21:31 ` Warner Losh
2022-06-07 20:14 ` [PATCH 2/6] bsd-user/freebsd/os-syscall.c: unlock_iovec Warner Losh
2022-06-07 21:28 ` Richard Henderson
2022-06-07 21:51 ` Warner Losh
2022-06-07 22:23 ` Richard Henderson
2022-06-07 23:35 ` Warner Losh
2022-06-08 2:02 ` Richard Henderson
2022-06-08 16:32 ` Warner Losh
2022-06-07 20:14 ` [PATCH 3/6] bsd-user/freebsd/os-syscall.c: Tracing and error boilerplate Warner Losh
2022-06-07 21:34 ` Richard Henderson [this message]
2022-06-07 21:56 ` Warner Losh
2022-06-07 20:14 ` [PATCH 4/6] bsd-user/bsd-file.h: Add implementations for read, pread, readv and preadv Warner Losh
2022-06-07 21:45 ` Richard Henderson
2022-06-08 2:02 ` Warner Losh
2022-06-07 20:14 ` [PATCH 5/6] bsd-user/bsd-file.h: Meat of the write system calls Warner Losh
2022-06-07 21:46 ` Richard Henderson
2022-06-07 20:14 ` [PATCH 6/6] bsd-user/freebsd/os-syscall.c: Implement exit Warner Losh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d00133d6-4c1f-637e-6a36-a68558bbefb0@linaro.org \
--to=richard.henderson@linaro.org \
--cc=arrowd@freebsd.org \
--cc=def@freebsd.org \
--cc=imp@bsdimp.com \
--cc=jrtc27@FreeBSD.org \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).