From: Paolo Bonzini <pbonzini@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 2/2] target-i386: sev: fail query-sev-capabilities if QEMU cannot use SEV
Date: Fri, 3 Jul 2020 18:10:36 +0200 [thread overview]
Message-ID: <d009abf4-6a78-bef2-5789-e51b7ec815e2@redhat.com> (raw)
In-Reply-To: <20200703160841.GA6680@work-vm>
On 03/07/20 18:08, Dr. David Alan Gilbert wrote:
>> + error_setg(errp, "KVM not enabled\n");
>> + return NULL;
>> + }
>> + if (kvm_vm_ioctl(kvm_state, KVM_MEMORY_ENCRYPT_OP, NULL) < 0) {
>> + error_setg(errp, "SEV is not enabled\n");
> Can you make that 'SEV is not enabled in KVM' so it's obvious
> that it's the KVM side and not the qemu side (like you've
> done in the previous patch).
Sure.
Paolo
next prev parent reply other threads:[~2020-07-03 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 15:45 [PATCH 0/2] error-reporting for query-sev-capabilities Paolo Bonzini
2020-06-30 15:45 ` [PATCH 1/2] target-i386: sev: provide proper error reporting " Paolo Bonzini
2020-07-01 14:11 ` Eric Blake
2020-06-30 15:45 ` [PATCH 2/2] target-i386: sev: fail query-sev-capabilities if QEMU cannot use SEV Paolo Bonzini
2020-07-01 14:12 ` Eric Blake
2020-07-03 16:08 ` Dr. David Alan Gilbert
2020-07-03 16:10 ` Paolo Bonzini [this message]
2020-06-30 16:09 ` [PATCH 0/2] error-reporting for query-sev-capabilities no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d009abf4-6a78-bef2-5789-e51b7ec815e2@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).