qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: "Zhao Liu" <zhao1.liu@intel.com>,
	"Eduardo Habkost" <eduardo@habkost.net>,
	"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Yanan Wang" <wangyanan55@huawei.com>,
	"Markus Armbruster" <armbru@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [PATCH] hw/core: Rename CpuTopology to CPUTopology
Date: Wed, 19 Jun 2024 16:53:00 +0200	[thread overview]
Message-ID: <d0135269-25c8-4156-ad0e-9b3b4b9159f5@redhat.com> (raw)
In-Reply-To: <ZnLwFPb3iLNiC8li@intel.com>

On 19/06/2024 16.49, Zhao Liu wrote:
> Hi maintainers,
> 
> Per my communication with Markus, it seems this renaming matches the
> "local consistency" principle in (include/hw/boards.h). :-)
> 
> So do you think this change is acceptable?

I don't care too much, both ways of naming look acceptable to me...
... but in case somebody else wants to merge this, FWIW:

s390x parts
Acked-by: Thomas Huth <thuth@redhat.com>

> 
> On Mon, May 27, 2024 at 09:18:37PM +0800, Zhao Liu wrote:
>> Date: Mon, 27 May 2024 21:18:37 +0800
>> From: Zhao Liu <zhao1.liu@intel.com>
>> Subject: [PATCH] hw/core: Rename CpuTopology to CPUTopology
>> X-Mailer: git-send-email 2.34.1
>>
>> Use CPUTopology to honor the generic style of CPU capitalization
>> abbreviations.
>>
>> Signed-off-by: Zhao Liu <zhao1.liu@intel.com>
>> ---
>>   * Split from the previous SMP cache RFC:
>>     https://lore.kernel.org/qemu-devel/20240220092504.726064-2-zhao1.liu@linux.intel.com/
>> ---
>>   hw/s390x/cpu-topology.c         |  6 +++---
>>   include/hw/boards.h             |  8 ++++----
>>   include/hw/s390x/cpu-topology.h |  6 +++---
>>   tests/unit/test-smp-parse.c     | 14 +++++++-------
>>   4 files changed, 17 insertions(+), 17 deletions(-)






      reply	other threads:[~2024-06-19 14:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 13:18 [PATCH] hw/core: Rename CpuTopology to CPUTopology Zhao Liu
2024-06-03 11:54 ` Markus Armbruster
2024-06-04  4:15   ` Zhao Liu
2024-06-04  5:29     ` Markus Armbruster
2024-06-04  6:36       ` Zhao Liu
2024-06-04  8:38         ` Markus Armbruster
2024-06-19 14:49 ` Zhao Liu
2024-06-19 14:53   ` Thomas Huth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d0135269-25c8-4156-ad0e-9b3b4b9159f5@redhat.com \
    --to=thuth@redhat.com \
    --cc=armbru@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=marcel.apfelbaum@gmail.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=wangyanan55@huawei.com \
    --cc=zhao1.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).