From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C31B0C28B2F for ; Tue, 11 Mar 2025 04:39:52 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1trrOG-0000d2-J5; Tue, 11 Mar 2025 00:38:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trrO1-0000JW-Io; Tue, 11 Mar 2025 00:38:37 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1trrNs-0002bo-J9; Tue, 11 Mar 2025 00:38:37 -0400 Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52AKccYU026709; Tue, 11 Mar 2025 04:38:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=UZ5XIB yipOqIM3T8XIDst+4cdfR8mV/vfO504Si383w=; b=UV0vMbeX1b/auLL11vbQHr cenzNvO4RD6VrgFb9f8Vq307lrsI7CS+6G+V0hVyAX0+MEzmgElw8gnEZ8gV8BED IQOdVQE5V+s/lx2fEBYm7jgedDo5om3VDZM4iLbAVsxR8jFJVec0jQUVjlOxt5qU 3mTarGP7wGYYLIOhD2t7SItx6GeN2ihPO0HRyx4xXxJgNfbeUb8MoQdfKNrGhVs/ N4iLR64QXLoejrqN7ibGdfV438E0fWj4LovDipPe3ppovRzxAVoo1tW9VGivI46o UO/iSap9Ipnih2NkUFRPx0lmuYj3Ze2mqxlfCeKzgwQn+v2RN2+CwIy/6v+TNZfw == Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45a7a19ge9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 04:38:26 +0000 (GMT) Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.18.0.8/8.18.0.8) with ESMTP id 52B4cPNi024563; Tue, 11 Mar 2025 04:38:25 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 45a7a19ge7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 04:38:25 +0000 (GMT) Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 52B3cXut014011; Tue, 11 Mar 2025 04:38:25 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 4592x1ste6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Mar 2025 04:38:25 +0000 Received: from smtpav01.wdc07v.mail.ibm.com (smtpav01.wdc07v.mail.ibm.com [10.39.53.228]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 52B4cOD860359028 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Mar 2025 04:38:24 GMT Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 067BF58059; Tue, 11 Mar 2025 04:38:24 +0000 (GMT) Received: from smtpav01.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8256C58055; Tue, 11 Mar 2025 04:38:21 +0000 (GMT) Received: from [9.109.242.165] (unknown [9.109.242.165]) by smtpav01.wdc07v.mail.ibm.com (Postfix) with ESMTP; Tue, 11 Mar 2025 04:38:21 +0000 (GMT) Message-ID: Date: Tue, 11 Mar 2025 10:08:19 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/7] hw/ppc: Log S0/S1 Interrupt triggers by OPAL To: Aditya Gupta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Nicholas Piggin , =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= , Sourabh Jain , Mahesh J Salgaonkar , Hari Bathini References: <20250217071934.86131-1-adityag@linux.ibm.com> <20250217071934.86131-2-adityag@linux.ibm.com> Content-Language: en-US From: Harsh Prateek Bora In-Reply-To: <20250217071934.86131-2-adityag@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: Ld276IToYsh3lj0jPDXUm-HG_QpYbisu X-Proofpoint-GUID: NwI-4NU5EDkFcNLMi1bNUax0LYfeh_nX X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1093,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-03-11_01,2025-03-07_03,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 mlxlogscore=891 malwarescore=0 clxscore=1015 mlxscore=0 impostorscore=0 bulkscore=0 spamscore=0 suspectscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2503110028 Received-SPF: pass client-ip=148.163.158.5; envelope-from=harshpb@linux.ibm.com; helo=mx0b-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 2/17/25 12:49, Aditya Gupta wrote: > During MPIPL (aka fadump), OPAL triggers the S0 SBE interrupt to trigger > MPIPL. > > Currently QEMU treats it as "Unimplemented", handle the interrupts by > just logging that the interrupt happened. > > Signed-off-by: Aditya Gupta > --- > hw/ppc/pnv_sbe.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/hw/ppc/pnv_sbe.c b/hw/ppc/pnv_sbe.c > index 74cee4eea7ad..62c94a04a2df 100644 > --- a/hw/ppc/pnv_sbe.c > +++ b/hw/ppc/pnv_sbe.c > @@ -109,6 +109,19 @@ static void pnv_sbe_power9_xscom_ctrl_write(void *opaque, hwaddr addr, > trace_pnv_sbe_xscom_ctrl_write(addr, val); > > switch (offset) { > + case SBE_CONTROL_REG_RW: > + switch (val) { > + case SBE_CONTROL_REG_S0: > + qemu_log_mask(LOG_UNIMP, "SBE: S0 Interrupt triggered\n"); > + break; > + case SBE_CONTROL_REG_S1: > + qemu_log_mask(LOG_UNIMP, "SBE: S1 Interrupt triggered\n"); > + break; > + default: > + qemu_log_mask(LOG_UNIMP, "SBE Unimplemented register: Ox%" This log could be made specific to SBE unimplemented register "bits", otherwise fall back to outer switch-default case. > + HWADDR_PRIx "\n", addr >> 3); > + } > + break; > default: > qemu_log_mask(LOG_UNIMP, "SBE Unimplemented register: Ox%" > HWADDR_PRIx "\n", addr >> 3);