From: Richard Henderson <richard.henderson@linaro.org>
To: "Rainer Müller" <raimue@codingfarm.de>, qemu-devel@nongnu.org
Cc: Laurent Vivier <laurent@vivier.eu>
Subject: Re: [PATCH v2] linux-user: Use memfd for open syscall emulation
Date: Fri, 29 Jul 2022 09:01:35 -0700 [thread overview]
Message-ID: <d03974ec-4b8b-2ba2-cfe8-5c235d937b76@linaro.org> (raw)
In-Reply-To: <20220729154951.76268-1-raimue@codingfarm.de>
On 7/29/22 08:49, Rainer Müller wrote:
> + /* create temporary file to map stat to */
> + tmpdir = getenv("TMPDIR");
> + if (!tmpdir)
> + tmpdir = "/tmp";
> + snprintf(filename, sizeof(filename), "%s/qemu-open.XXXXXX", tmpdir);
> + fd = mkstemp(filename);
> + if (fd < 0) {
> + return fd;
> + }
We've been using g_file_open_tmp elsewhere; probably good to follow suit here.
r~
next prev parent reply other threads:[~2022-07-29 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 16:28 [PATCH] linux-user: Use memfd for open syscall emulation Rainer Müller
2022-07-25 18:37 ` Richard Henderson
2022-07-29 15:49 ` [PATCH v2] " Rainer Müller
2022-07-29 16:01 ` Richard Henderson [this message]
2022-07-29 21:19 ` Rainer Müller
2022-07-29 21:29 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d03974ec-4b8b-2ba2-cfe8-5c235d937b76@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
--cc=raimue@codingfarm.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).