From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: "Alex Bennée" <alex.bennee@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>
Cc: Fam Zheng <fam@euphon.net>, Thomas Huth <thuth@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Wainer dos Santos Moschetta <wainersm@redhat.com>
Subject: Re: [PULL 7/8] gitlab: create a build-deprecated target
Date: Wed, 16 Sep 2020 15:52:15 +0200 [thread overview]
Message-ID: <d04bee00-624f-c48c-89a1-d5e6cbbddb76@amsat.org> (raw)
In-Reply-To: <87imcdzwh7.fsf@linaro.org>
On 9/16/20 3:23 PM, Alex Bennée wrote:
>
> Peter Maydell <peter.maydell@linaro.org> writes:
>
>> On Wed, 16 Sep 2020 at 13:27, Alex Bennée <alex.bennee@linaro.org> wrote:
>>>
>>> These targets might be deprecated but we should keep them building
>>> before the final axe comes down. Lets keep them all in one place and
>>> don't hold up the CI if they do fail. They are either poorly tested or
>>> already flaky anyway.
>>>
>>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>>> Acked-by: Thomas Huth <thuth@redhat.com>
>>> Message-Id: <20200915134317.11110-8-alex.bennee@linaro.org>
>>>
>>> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
>>> index 72e8604579ee..f027b55aef15 100644
>>> --- a/.gitlab-ci.yml
>>> +++ b/.gitlab-ci.yml
>>> @@ -254,6 +254,16 @@ build-clang:
>>> ppc-softmmu s390x-softmmu arm-linux-user
>>> MAKE_CHECK_ARGS: check
>>>
>>> +# These targets are on the way out
>>> +build-deprecated:
>>> + <<: *native_build_job_definition
>>> + variables:
>>> + IMAGE: debian-all-test-cross
>>> + CONFIGURE_ARGS: --disable-docs --disable-tools --disable-system
>>> + MAKE_CHECK_ARGS: check-tcg
>>> + TARGETS: ppc64abi32-linux-user tilegx-linux-user
>>> + allow_failure: true
>>
>> It's kind of awkward to have the CI config need to be updated when
>> we mark a config as deprecated. Can we have something so that
>> the CI just arranges to build all of the deprecated targets?
>
> You mean a configure --enable-deprecated-targets?
>
>>
>> (As demonstration, this list is missing unicore32, which is also
>> deprecated.)
>
> That was fixed up in the next patch.
>
>> Also, "allow_failure: true" seems wrong to me. These targets
>> are only deprecated, which means we promise that the feature
>> should still work (to whatever extent it already did) for the 2
>> releases in which it is deprecated. We want our CI to tell us
>> if it fails to compile or fails tests, because we would need to
>> fix those bugs for a release.
Should we stop building the ppc64abi32 target instead?
From c609274b853 ("docs/system/deprecated: mark
ppc64abi32-linux-user for deprecation"):
The ppc64abi32 architecture has a number of issues which regularly
trip up our CI testing and is suspected to be quite broken. For that
reason the maintainers strongly suspect no one actually uses it.
>
> I can revert that bit.
>
next prev parent reply other threads:[~2020-09-16 13:53 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-16 12:26 [PULL 0/8] configure deprecation, linux-user and test fix Alex Bennée
2020-09-16 12:26 ` [PULL 1/8] linux-user: test, don't assert addr != test in pgb_reserved_va Alex Bennée
2020-09-16 12:26 ` [Bug 1895080] " Alex Bennée
2020-09-16 12:26 ` [PULL 2/8] iotests: Drop readlink -f Alex Bennée
2020-09-16 12:26 ` [PULL 3/8] configure: move deprecated feature processing to supported_target Alex Bennée
2020-09-16 12:26 ` [PULL 4/8] configure: also skip deprecated targets with target-list-exclude Alex Bennée
2020-09-16 12:26 ` [PULL 5/8] configure: clean-up the target-list-exclude logic Alex Bennée
2020-09-16 12:26 ` [PULL 6/8] configure: include tilegx-linux-user in the deprecation logic Alex Bennée
2020-09-16 12:26 ` [PULL 7/8] gitlab: create a build-deprecated target Alex Bennée
2020-09-16 12:40 ` Peter Maydell
2020-09-16 13:23 ` Alex Bennée
2020-09-16 13:52 ` Philippe Mathieu-Daudé [this message]
2020-09-25 15:54 ` Peter Maydell
2020-09-25 18:34 ` Richard Henderson
2020-09-25 18:47 ` Peter Maydell
2020-09-16 12:26 ` [PULL 8/8] configure: add [lm32|unicore32]-softmmu to deprecation logic Alex Bennée
2020-09-17 19:40 ` [PULL 0/8] configure deprecation, linux-user and test fix Peter Maydell
-- strict thread matches above, loose matches on Subject: below --
2020-09-15 13:43 [PATCH v2 0/8] configure deprecation, linux-user and iotest fixes Alex Bennée
2020-09-15 13:43 ` [PATCH v2 1/8] linux-user: test, don't assert addr != test in pgb_reserved_va Alex Bennée
2020-09-15 13:43 ` [Bug 1895080] " Alex Bennée
2020-09-15 15:58 ` Laurent Vivier
2020-09-15 15:58 ` [Bug 1895080] " Laurent Vivier
2020-09-15 17:13 ` Richard Henderson
2020-09-15 13:43 ` [PATCH v2 2/8] iotests: Drop readlink -f Alex Bennée
2020-09-15 17:14 ` Richard Henderson
2020-09-15 13:43 ` [PATCH v2 3/8] configure: move deprecated feature processing to supported_target Alex Bennée
2020-09-15 13:51 ` Michael Tokarev
2020-09-15 13:43 ` [PATCH v2 4/8] configure: also skip deprecated targets with target-list-exclude Alex Bennée
2020-09-15 17:16 ` Richard Henderson
2020-09-15 13:43 ` [PATCH v2 5/8] configure: clean-up the target-list-exclude logic Alex Bennée
2020-09-15 17:17 ` Richard Henderson
2020-09-15 13:43 ` [PATCH v2 6/8] configure: include tilegx-linux-user in the deprecation logic Alex Bennée
2020-09-15 17:17 ` Richard Henderson
2020-09-15 17:47 ` Philippe Mathieu-Daudé
2020-09-15 13:43 ` [PATCH v2 7/8] gitlab: create a build-deprecated target Alex Bennée
2020-09-15 13:43 ` [PATCH v2 8/8] configure: add [lm32|unicore32]-softmmu to deprecation logic Alex Bennée
2020-09-15 17:20 ` Richard Henderson
2020-10-29 12:25 ` Thomas Huth
2020-10-29 14:42 ` Alex Bennée
2020-10-29 15:28 ` Thomas Huth
2020-09-14 15:07 [PATCH v1 0/6] deprecation and linux-user tweaks (+test fix) Alex Bennée
2020-09-14 15:07 ` [PATCH v1 1/6] linux-user: test, don't assert addr != test in pgb_reserved_va Alex Bennée
2020-09-14 15:07 ` [Bug 1895080] " Alex Bennée
2020-09-14 15:07 ` [PATCH v1 2/6] configure: use add_to for tweaking deprecated_features Alex Bennée
2020-09-14 16:14 ` Thomas Huth
2020-09-14 15:07 ` [PATCH v1 3/6] configure: also skip deprecated targets with target-list-exclude Alex Bennée
2020-09-14 19:17 ` Peter Maydell
2020-09-15 9:22 ` Alex Bennée
2020-09-14 15:07 ` [PATCH v1 4/6] configure: include tilegx-linux-user in the auto-exclude logic Alex Bennée
2020-09-15 12:58 ` Philippe Mathieu-Daudé
2020-09-14 15:07 ` [PATCH v1 5/6] gitlab: create a build-deprecated target Alex Bennée
2020-09-14 15:15 ` Philippe Mathieu-Daudé
2020-09-14 16:16 ` Thomas Huth
2020-09-14 15:07 ` [PATCH v1 6/6] iotests: Work around failing readlink -f Alex Bennée
2020-09-10 3:46 [Bug 1895080] [NEW] pgb_reserved_va: Assertion `addr == test' failed Hansni Bu
2020-09-10 6:18 ` [Bug 1895080] " Laurent Vivier
2020-09-10 19:04 ` [Bug 1895080] [NEW] " Laurent Vivier
2020-09-11 5:57 ` Hansni Bu
2020-09-11 9:34 ` Alex Bennée
2020-09-11 9:38 ` Alex Bennée
2020-09-11 10:18 ` Hansni Bu
2020-09-11 11:54 ` Alex Bennée
2020-09-11 11:54 ` Alex Bennée
2020-09-11 12:32 ` Hansni Bu
2020-09-11 14:47 ` Alex Bennée
2020-09-11 14:47 ` Alex Bennée
2020-09-11 8:30 ` [Bug 1895080] " Alex Bennée
2020-09-11 9:31 ` Hansni Bu
2020-09-11 14:56 ` [RFC PATCH] linux-user: test, don't assert addr != test in pgb_reserved_va Alex Bennée
2020-09-11 14:56 ` [Bug 1895080] Re: pgb_reserved_va: Assertion `addr == test' failed Alex Bennée
2020-09-15 2:09 ` Hansni Bu
2020-11-08 9:43 ` Thomas Huth
2020-12-10 9:17 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d04bee00-624f-c48c-89a1-d5e6cbbddb76@amsat.org \
--to=f4bug@amsat.org \
--cc=alex.bennee@linaro.org \
--cc=fam@euphon.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).