From: Richard Henderson <rth@twiddle.net>
To: David Hildenbrand <david@redhat.com>, qemu-devel@nongnu.org
Cc: thuth@redhat.com, cohuck@redhat.com,
Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH v1] s390x/kvm: fix and cleanup storing CPU status
Date: Fri, 22 Sep 2017 09:05:19 -0500 [thread overview]
Message-ID: <d05db15e-11f7-120b-88fb-156620b2ee6b@twiddle.net> (raw)
In-Reply-To: <cd4dda74-77c1-27a2-7427-d963a51e06ca@redhat.com>
On 09/22/2017 08:18 AM, David Hildenbrand wrote:
> On 22.09.2017 15:12, Richard Henderson wrote:
>> I don't believe you need to use QEMU_PACKED. Unless the "addr" that's passed
>> in can really be arbitrary? (If so, the memory returned by
>> cpu_physical_memory_map will be unaligned and so we do need the PACKED to force
>> the compiler to generate unaligned stores into the structure.)
>
> The address is either 0x1200 or it is masked with 0x7ffffe00u.
>
> So most probably this should be fine without QEMU_PACKED, right?
Yes.
r~
next prev parent reply other threads:[~2017-09-22 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 21:30 [Qemu-devel] [PATCH v1] s390x/kvm: fix and cleanup storing CPU status David Hildenbrand
2017-09-22 13:12 ` Richard Henderson
2017-09-22 13:18 ` David Hildenbrand
2017-09-22 14:05 ` Richard Henderson [this message]
2017-09-22 13:37 ` Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d05db15e-11f7-120b-88fb-156620b2ee6b@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).