From: Eric Blake <eblake@redhat.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files"
Date: Fri, 4 May 2018 07:52:43 -0500 [thread overview]
Message-ID: <d0616c04-9db3-58a9-997d-da1055718e51@redhat.com> (raw)
In-Reply-To: <20180504054241.6833-1-armbru@redhat.com>
On 05/04/2018 12:42 AM, Markus Armbruster wrote:
> This reverts commit 9578f8cc3e8bd71de8e3f543dc7b95644d64824e.
>
> The patch snuck in by accident without having been posted to
> qemu-devel. It's entirely redundant: existing target print-% already
> serves the purpose.
>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> Makefile | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/Makefile b/Makefile
> index d71dd5bea4..f36110d4aa 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1047,9 +1047,6 @@ endif
> include $(SRC_PATH)/tests/docker/Makefile.include
> include $(SRC_PATH)/tests/vm/Makefile.include
>
> -printgen:
> - @echo $(GENERATED_FILES)
> -
> .PHONY: help
> help:
> @echo 'Generic targets:'
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2018-05-04 12:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 5:42 [Qemu-devel] [PATCH] Revert "Makefile: add target to print generated files" Markus Armbruster
2018-05-04 12:52 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0616c04-9db3-58a9-997d-da1055718e51@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).