Re: [PATCH] accel/tcg: Add stub for probe_access()

[David Hildenbrand <david@redhat.com>]

On 23.04.20 09:59, Philippe Mathieu-Daudé wrote:
> On Thu, Apr 23, 2020 at 9:49 AM David Hildenbrand <david@redhat.com> wrote:
>>
>> On 23.04.20 09:10, Philippe Mathieu-Daudé wrote:
>>> The TCG helpers where added in b92e5a22ec3 in softmmu_template.h.
>>> probe_write() was added in there in 3b4afc9e75a to be moved out
>>> to accel/tcg/cputlb.c in 3b08f0a9254, and was later refactored
>>> as probe_access() in c25c283df0f.
>>> Since it is a TCG specific helper, add a stub to avoid failures
>>> when building without TCG, such:
>>>
>>>   target/arm/helper.o: In function `probe_read':
>>>   include/exec/exec-all.h:345: undefined reference to `probe_access'
>>
>> I think you're missing the most important commit:
>>
>> 0d57b4999220 ("target/arm: Add support for DC CVAP & DC CVADP ins")
>>
>> I do wonder if dccvap_writefn() and calling code should be compiled for
>> TCG only (CONFIG_TCG). I assume it is only called from TCG code -
>> otherwise it would already be semi-broken.
> 
> I can only recommend you to read the thread after this previous patch,
> as I don't have the knowledge to explain...:
> https://www.mail-archive.com/qemu-devel@nongnu.org/msg689115.html

Yeah, me neither. Sounds wrong to me to have TCG-only code stick around
in !CONFIG_TCG builds. But I am pretty sure ARM people know what they
are doing.


-- 
Thanks,

David / dhildenb