Re: [PATCH v2 2/2] hw/ppc/e500: Reuse TYPE_GPIO_PWR

["Philippe Mathieu-Daudé" <philmd@linaro.org>]

On 5/10/24 07:02, Bernhard Beschow wrote:
> Taking inspiration from the ARM virt machine, port away from
> qemu_allocate_irq() by reusing TYPE_GPIO_PWR.
> 
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> ---
>   hw/ppc/e500.c  | 16 ++++------------
>   hw/ppc/Kconfig |  1 +
>   2 files changed, 5 insertions(+), 12 deletions(-)


> @@ -892,13 +890,6 @@ static DeviceState *ppce500_init_mpic(PPCE500MachineState *pms,
>       return dev;
>   }
>   
> -static void ppce500_power_off(void *opaque, int line, int on)
> -{
> -    if (on) {
> -        qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
> -    }
> -}
> -
>   void ppce500_init(MachineState *machine)
>   {
>       MemoryRegion *address_space_mem = get_system_memory();
> @@ -1086,7 +1077,7 @@ void ppce500_init(MachineState *machine)
>       sysbus_create_simple("e500-spin", pmc->spin_base, NULL);
>   
>       if (pmc->has_mpc8xxx_gpio) {
> -        qemu_irq poweroff_irq;
> +        DeviceState *gpio_pwr_dev;

Can we keep a reference in PPCE500MachineState?

Otherwise,
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

>   
>           dev = qdev_new("mpc8xxx_gpio");
>           s = SYS_BUS_DEVICE(dev);
> @@ -1096,8 +1087,9 @@ void ppce500_init(MachineState *machine)
>                                       sysbus_mmio_get_region(s, 0));
>   
>           /* Power Off GPIO at Pin 0 */
> -        poweroff_irq = qemu_allocate_irq(ppce500_power_off, NULL, 0);
> -        qdev_connect_gpio_out(dev, 0, poweroff_irq);
> +        gpio_pwr_dev = sysbus_create_simple("gpio-pwr", -1, NULL);
> +        qdev_connect_gpio_out(dev, 0, qdev_get_gpio_in_named(gpio_pwr_dev,
> +                                                             "shutdown", 0));
>       }