From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97951C47079 for ; Mon, 8 Jan 2024 13:21:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMpYf-0000nC-34; Mon, 08 Jan 2024 08:20:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMpYZ-0000mj-IP for qemu-devel@nongnu.org; Mon, 08 Jan 2024 08:20:44 -0500 Received: from mail-wr1-x433.google.com ([2a00:1450:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMpYX-0002PH-Bc for qemu-devel@nongnu.org; Mon, 08 Jan 2024 08:20:42 -0500 Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-3374eb61cbcso1858671f8f.0 for ; Mon, 08 Jan 2024 05:20:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704720039; x=1705324839; darn=nongnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=f0KCTCDXugTzkY37kFn8h1zKyHtmM6/s4WxalUNP9Qo=; b=j/MxfxO1y84dyjOvanL2s30uClzZV7UjYutudOXy1kRvEt4Cz7JUdQ/43OCYsG4Ygg vG9lS+10F9lB7QQ8YGPHntk/Ou0HRtkZGMSMFqSG8NQr54aSTyyGxaAZ7XH+mNBxC8F2 DyE+O/5m7sedkzzeXDFsnrX2IGTooDYrTFbhOABGhF7rnelU0NX5df5FPTBiTwBHVGmn 6bHazaysDDHQr1H7yVpBNi+0geNLl+vZmWr23LRKXYvMGMBQaI0aXsJjgtw0fQYES0XL rlkXeHibeULogKZQI9b6ndU5uK7hIeaJ+RVL8ahOzytLf0s3DbsHHtZlBSCHc0d/S7rF wUzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704720039; x=1705324839; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=f0KCTCDXugTzkY37kFn8h1zKyHtmM6/s4WxalUNP9Qo=; b=vM9EN/bxvSpbYBByxEznbaMHdJuVHOMTPODZ6kuHfJ4dVJnWwXtXWGYU6tOkyihkcR zDq95KXvNCJnELkWk4j2Tlmreb4Sbf3DdPHrHWjGq+cXrrblqUm/rhdtZIXJUz2EbXa1 qtdHg44TKNCpM4rlr1aGeEfXT5k7lWllhMUpMOcFPkO9/j23OQ9C1BKS/EfahtbvXMx3 7dWDGxD7rllsxJg3+IEOMc4KZiij1uGiOqxVkku1sLZMD0XF4FcOXShYKbc8jrmG1I32 a42JH1rZaADio7tXDwo+c2Dp95DEEc6E1N2x3s+2LdEQvio54xFr5SuTjDtyfMTJa5A3 YoOg== X-Gm-Message-State: AOJu0YzNfSa1tuZF9rBAeh54sCfdlqA6ZCJJObeleLTobaeeTrECl1Zk 7f8h1m2T0x+W6bx4h7jdfw8Ho4domlf0vA== X-Google-Smtp-Source: AGHT+IEohQQ6MspPaUlVlTguNr9NdjdE58AEbSCYHcp7Zsygl0GrhLjMbI03UsTaP6AVb2Ynf4uSQw== X-Received: by 2002:adf:f3cf:0:b0:336:654a:bff2 with SMTP id g15-20020adff3cf000000b00336654abff2mr1869449wrp.10.1704720039303; Mon, 08 Jan 2024 05:20:39 -0800 (PST) Received: from [192.168.1.102] ([176.176.175.62]) by smtp.gmail.com with ESMTPSA id a5-20020adffb85000000b003376af392e5sm2196749wrr.38.2024.01.08.05.20.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Jan 2024 05:20:38 -0800 (PST) Message-ID: Date: Mon, 8 Jan 2024 14:20:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] hw/arm: add PCIe to Freescale i.MX6 Content-Language: en-US To: Nikita Ostrenkov , Thomas Huth Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org, Jean-Christophe Dubois , Peter Maydell , Paolo Bonzini References: <20240107165702.47819-1-n.ostrenkov@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::433; envelope-from=philmd@linaro.org; helo=mail-wr1-x433.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org (+Thomas) On 8/1/24 13:58, Nikita Ostrenkov wrote: > Hi! Thanks! I'll send a new version of this patch. > > But what about fsl imx7? Should it also have PCIE_DEVICES? Yeah I think so, we missed this in commit 02047622b7 ("hw/arm: Express dependencies of the remaining IMX boards with Kconfig"). > > пн, 8 янв. 2024 г. в 15:20, Philippe Mathieu-Daudé >: > > Hi Nikita, > > On 7/1/24 17:57, Nikita Ostrenkov wrote: > > Signed-off-by: Nikita Ostrenkov > > > --- > >   hw/arm/Kconfig            |  3 +++ > >   hw/arm/fsl-imx6.c         | 25 ++++++++++++++++++++++ > >   include/hw/arm/fsl-imx6.h | 44 > ++++++++++++++++++++------------------- > >   3 files changed, 51 insertions(+), 21 deletions(-) > > > > diff --git a/hw/arm/Kconfig b/hw/arm/Kconfig > > index 660f49db49..575bb68c76 100644 > > --- a/hw/arm/Kconfig > > +++ b/hw/arm/Kconfig > > @@ -530,13 +530,16 @@ config FSL_IMX31 > > > >   config FSL_IMX6 > >       bool > > +    imply PCI_DEVICES > > This should be PCIE_DEVICES. > > >       imply I2C_DEVICES > >       select A9MPCORE > > +    select PCI > > Incorrect, should be PCI_EXPRESS, but this is already > (indirectly) selected by PCI_EXPRESS_DESIGNWARE which > you select below, so not needed. > > >       select IMX > >       select IMX_FEC > >       select IMX_I2C > >       select IMX_USBPHY > >       select WDT_IMX2 > > +    select PCI_EXPRESS_DESIGNWARE > >       select SDHCI >