From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>,
Leif Lindholm <leif.lindholm@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM
Date: Wed, 21 Dec 2016 18:58:44 +0100 [thread overview]
Message-ID: <d0a8813e-1407-f6a7-a70e-387071aed93a@redhat.com> (raw)
In-Reply-To: <20161221145934.219d73fd@nial.brq.redhat.com>
On 21/12/2016 14:59, Igor Mammedov wrote:
>> Apparently a misunderstanding of the underlying command line handling
>> mechanics.
>>
>>> Also this patch would break build for targets that don't link smbios.c
>>> (i.e. which don't have CONFIG_SMBIOS=y)
>>
>> Ah, I hadn't spotted that - apologies.
>
> Just do 1 build for all targets before posting patches to avoid
> such kind of errors.
>
>> So a simpler, and more correct fix would rather be to change the
>> #ifdef TARGET_I386
>> in arch_init.c to
>> #ifdef CONFIG_SMBIOS
>
> it looks better to me than enumerating targets explicitly,
> CCing Paolo for another opinion
I don't think CONFIG_SMBIOS is visible from C, is it?
However, the solution is to:
1) add a smbios-stub.c file to hw/smbios, containing a dummy
implementation of smbios_entry_add. For the Makefile magic see
hw/pci/Makefile.objs.
2) add an Error * argument to smbios_entry_add, and make the stub
version fail
3) remove do_smbios_option altogether, and make vl.c call
smbios_entry_add directly.
Paolo
next prev parent reply other threads:[~2016-12-21 17:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 15:23 [Qemu-devel] [PATCH] smbios: stop ignoring command line options for TARGET_ARM Leif Lindholm
2016-12-16 15:31 ` no-reply
2016-12-19 19:33 ` Leif Lindholm
2016-12-21 10:51 ` Igor Mammedov
2016-12-21 12:35 ` Leif Lindholm
2016-12-21 13:59 ` Igor Mammedov
2016-12-21 17:58 ` Paolo Bonzini [this message]
2016-12-22 15:18 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0a8813e-1407-f6a7-a70e-387071aed93a@redhat.com \
--to=pbonzini@redhat.com \
--cc=imammedo@redhat.com \
--cc=leif.lindholm@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).