From: Amit Shah <amit@infradead.org>
To: Filip Hejsek <filip.hejsek@gmail.com>,
Szymon Lukasz <noh4hss@gmail.com>,
qemu-devel@nongnu.org
Cc: lvivier@redhat.com, berrange@redhat.com, amit@kernel.org,
mst@redhat.com, marcandre.lureau@redhat.com,
pbonzini@redhat.com
Subject: Re: [PATCH v3 0/9] virtio-console: notify about the terminal size
Date: Mon, 23 Oct 2023 10:09:01 +0200 [thread overview]
Message-ID: <d0acd0d9e6dc1e73477126348816a23e18b9e931.camel@infradead.org> (raw)
In-Reply-To: <3913e8227c343a5d9bfcc2ac1f01d9bd8eceac7a.camel@gmail.com>
On Mon, 2023-10-23 at 05:12 +0200, Filip Hejsek wrote:
> I have found this 3 year old patch adding virtio console resize
> support, which seems to have been forgotten at that time. I would like
> to see this feature merged.
>
> Szymon, you have originally submitted this patch, would you be willing
> to update it for the latest development tree and resubmit it?
>
> If it turns out that Szymon doesn't want to work on this anymore for
> any reason (or doesn't respond), could I resubmit the patch myself?
> The contributing guidelines don't say anything about this. I'm
> especially unsure how to deal with Signed-off-by, as in such case I
> would be (re)submitting sombody else's work, but potentially with my
> modifications. I'm willing to update and test the patch, and if
> necessary, address any review feedback.
You should keep Szymon's SOB, mention your changes in the commit
message below that SOB and put in your own after.
Amit
next prev parent reply other threads:[~2023-10-23 8:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 16:40 [PATCH v3 0/9] virtio-console: notify about the terminal size Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 1/9] chardev: add cols, rows fields Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 2/9] chardev: add CHR_EVENT_RESIZE Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 3/9] chardev: add qemu_chr_resize() Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 4/9] char-mux: add support for the terminal size Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 5/9] main-loop: change the handling of SIGWINCH Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 6/9] char-stdio: add support for the terminal size Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 7/9] qmp: add chardev-resize command Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 8/9] virtio-serial-bus: add terminal resize messages Szymon Lukasz
2020-06-29 16:40 ` [PATCH v3 9/9] virtio-console: notify the guest about terminal resizes Szymon Lukasz
2023-10-23 3:12 ` [PATCH v3 0/9] virtio-console: notify about the terminal size Filip Hejsek
2023-10-23 8:09 ` Amit Shah [this message]
2025-09-09 13:48 ` Dominique Martinet
2025-09-09 19:24 ` Michael S. Tsirkin
2025-09-11 14:08 ` Filip Hejsek
2025-09-11 16:43 ` Filip Hejsek
2025-09-11 21:19 ` Filip Hejsek
2025-09-11 21:53 ` Dominique Martinet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0acd0d9e6dc1e73477126348816a23e18b9e931.camel@infradead.org \
--to=amit@infradead.org \
--cc=amit@kernel.org \
--cc=berrange@redhat.com \
--cc=filip.hejsek@gmail.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=noh4hss@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).