From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6591BC433F5 for ; Thu, 26 May 2022 14:43:59 +0000 (UTC) Received: from localhost ([::1]:42956 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nuEiU-00087j-At for qemu-devel@archiver.kernel.org; Thu, 26 May 2022 10:43:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuEgn-00067t-Qw for qemu-devel@nongnu.org; Thu, 26 May 2022 10:42:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31047) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nuEgh-0005pb-Bd for qemu-devel@nongnu.org; Thu, 26 May 2022 10:42:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653576126; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WGBAJ1lGNZT1iOmAa4CZWsdIIaliSyvd/v6LvFsX6VQ=; b=UVtz0EQDX3bozEIqWzk2xig96x9xPZjN0y/jxIhjn8D1CBoosrui8hSH4TFTV4UDIxwA8y Qv/Z5E/nt28trXWdOfvKQYkwDun55wUJQGE0TvVhgrBsh8m1nixRQIfSsrU7ff8Am6RfUG rPiHSegT/aE/luVKH+IvNNEI3RRyzrE= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-658-lPqYX8i8Px-frzH9pGv1VQ-1; Thu, 26 May 2022 10:42:00 -0400 X-MC-Unique: lPqYX8i8Px-frzH9pGv1VQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D4E273C222CB; Thu, 26 May 2022 14:41:59 +0000 (UTC) Received: from [10.72.12.91] (ovpn-12-91.pek2.redhat.com [10.72.12.91]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 005C51730C; Thu, 26 May 2022 14:41:52 +0000 (UTC) Subject: Re: [PATCH 0/3] hw/acpi/aml-build: Fix {socket, cluster, core} IDs in PPTT To: Igor Mammedov Cc: qemu-arm@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com, ani@anisinha.ca, drjones@redhat.com, wangyanan55@huawei.com, Jonathan.Cameron@Huawei.com, peter.maydell@linaro.org, berrange@redhat.com, thuth@redhat.com, eduardo@habkost.net, lvivier@redhat.com, zhenyzha@redhat.com, shan.gavin@gmail.com References: <20220518092141.1050852-1-gshan@redhat.com> <5719fb28-0ab8-d8f8-c2c3-2e600451d6d8@redhat.com> <20220526142712.3bab443c@redhat.com> From: Gavin Shan Message-ID: Date: Thu, 26 May 2022 22:41:50 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: <20220526142712.3bab443c@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 Received-SPF: pass client-ip=170.10.133.124; envelope-from=gshan@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -21 X-Spam_score: -2.2 X-Spam_bar: -- X-Spam_report: (-2.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.082, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Gavin Shan Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/26/22 8:27 PM, Igor Mammedov wrote: > On Thu, 26 May 2022 19:37:47 +0800 > Gavin Shan wrote: >> >> On 5/18/22 5:21 PM, Gavin Shan wrote: >>> The {socket, cluster, core} IDs detected from Linux guest aren't >>> matching with what have been provided in PPTT. The flag used for >>> 'ACPI Processor ID valid' is missed for {socket, cluster, core} >>> nodes. In this case, Linux guest takes the offset between the >>> node and PPTT header as the corresponding IDs, as the following >>> logs show. >>> >>> >>> /home/gavin/sandbox/qemu.main/build/qemu-system-aarch64 \ >>> -accel kvm -machine virt,gic-version=host -cpu host \ >>> -smp 8,sockets=2,clusters=2,cores=2,threads=1 >>> : >>> >>> # cd /sys/devices/system/cpu >>> # for i in `seq 0 15`; do cat cpu$i/topology/physical_package_id; done >>> 36 36 36 36 36 36 36 36 >>> 336 336 336 336 336 336 336 336 >>> # for i in `seq 0 15`; do cat cpu$i/topology/cluster_id; done >>> 56 56 56 56 196 196 196 196 >>> 356 356 356 356 496 496 496 496 >>> # for i in `seq 0 15`; do cat cpu$i/topology/core_id; done >>> 76 76 136 136 216 216 276 276 >>> 376 376 436 436 516 516 576 576 >>> >>> This fixes the issue by setting 'ACPI Processor ID valid' flag for >>> {socket, cluster, core} nodes. With this applied, the IDs are exactly >>> what have been provided in PPTT. I also checked the PPTT table on my >>> host, where the 'ACPI Processor ID valid' is set for cluster/core nodes, >>> but missed from socket nodes. >>> >>> host# pwd >>> /sys/devices/system/cpu >>> host# cat cpu0/topology/physical_package_id; \ >>> cat cpu0/topology/cluster_id; \ >>> cat cpu0/topology/core_id >>> 36 0 0 >>> >>> Gavin Shan (3): >>> tests/acpi/virt: Allow PPTT ACPI table changes >>> hw/acpi/aml-build: Fix {socket, cluster, core} IDs in PPTT >>> tests/acpi/virt: Update PPTT ACPI table >>> >>> hw/acpi/aml-build.c | 9 ++++++--- >>> tests/data/acpi/virt/PPTT | Bin 96 -> 96 bytes >>> 2 files changed, 6 insertions(+), 3 deletions(-) >>> >> >> Could you help to review this tiny series? Thanks in advance. > done, so far I'm not convinced that it's QEMU's fault. see comment on 2/3 > Thanks, Igor. I just replied. Lets discuss this through in the loop of PATCH[2/3]. Thanks, Gavin