From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v1 05/14] configure: favour gdb-multiarch if we have it
Date: Thu, 23 Apr 2020 22:28:50 +0200 [thread overview]
Message-ID: <d0da4db0-7049-7130-486d-e338d8243faf@redhat.com> (raw)
In-Reply-To: <20200423170557.31106-6-alex.bennee@linaro.org>
On 4/23/20 7:05 PM, Alex Bennée wrote:
> As gdb will generally be talking to "foreign" guests lets use that if
> we can. Otherwise the chances of gdb barfing are considerably higher.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 23b5e93752..c58787100f 100755
> --- a/configure
> +++ b/configure
> @@ -303,7 +303,7 @@ libs_qga=""
> debug_info="yes"
> stack_protector=""
> use_containers="yes"
> -gdb_bin=$(command -v "gdb")
> +gdb_bin=$(command -v "gdb-multiarch" || command -v "gdb")
>
Good one!
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
> if test -e "$source_path/.git"
> then
>
next prev parent reply other threads:[~2020-04-23 20:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 17:05 [PATCH for 5.1 v1 00/14] guest_base, gdbstub and Travis Alex Bennée
2020-04-23 17:05 ` [PATCH v1 01/14] linux-user: completely re-write init_guest_space Alex Bennée
2020-04-23 17:05 ` [PATCH v1 02/14] exec/cpu-all: Use bool for have_guest_base Alex Bennée
2020-04-23 17:05 ` [PATCH v1 03/14] accel/tcg: Relax va restrictions on 64-bit guests Alex Bennée
2020-04-23 17:05 ` [PATCH v1 04/14] .gitignore: include common build sub-directories Alex Bennée
2020-04-23 17:05 ` [PATCH v1 05/14] configure: favour gdb-multiarch if we have it Alex Bennée
2020-04-23 20:28 ` Philippe Mathieu-Daudé [this message]
2020-04-23 17:05 ` [PATCH v1 06/14] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers Alex Bennée
2020-04-23 17:05 ` [PATCH v1 07/14] tests/tcg: better trap gdb failures Alex Bennée
2020-04-23 17:05 ` [PATCH v1 08/14] tests/tcg: drop inferior.was_attached() test Alex Bennée
2020-04-23 17:05 ` [PATCH v1 09/14] gdbstub: eliminate gdbserver_fd global Alex Bennée
2020-04-23 20:30 ` Philippe Mathieu-Daudé
2020-04-23 17:05 ` [PATCH v1 10/14] gdbstub/linux-user: support debugging over a unix socket Alex Bennée
2020-04-23 17:05 ` [PATCH v1 11/14] tests/guest-debug: use the unix socket for linux-user tests Alex Bennée
2020-04-23 17:05 ` [PATCH v1 12/14] tests/tcg: add a multiarch linux-user gdb test Alex Bennée
2020-04-23 17:05 ` [PATCH v1 13/14] .travis.yml: show free disk space at end of run Alex Bennée
2020-04-23 20:27 ` Philippe Mathieu-Daudé
2020-04-23 17:05 ` [PATCH v1 14/14] .travis.yml: drop MacOSX Alex Bennée
2020-04-23 20:28 ` Philippe Mathieu-Daudé
2020-04-23 18:15 ` [PATCH for 5.1 v1 00/14] guest_base, gdbstub and Travis no-reply
2020-04-23 18:17 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0da4db0-7049-7130-486d-e338d8243faf@redhat.com \
--to=philmd@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).