From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55359)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1fiNTJ-00030E-BZ
	for qemu-devel@nongnu.org; Wed, 25 Jul 2018 13:21:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <thuth@redhat.com>) id 1fiNTG-0006OF-BS
	for qemu-devel@nongnu.org; Wed, 25 Jul 2018 13:21:09 -0400
References: <1532521224-27235-1-git-send-email-thuth@redhat.com>
	<20180725154837.5f9c6735.cohuck@redhat.com>
From: Thomas Huth <thuth@redhat.com>
Message-ID: <d0deae36-1183-e3ef-764e-79b4b68f207e@redhat.com>
Date: Wed, 25 Jul 2018 19:20:59 +0200
MIME-Version: 1.0
In-Reply-To: <20180725154837.5f9c6735.cohuck@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-3.1 00/10] Move virtio-ccw devices to
 separate files
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cohuck@redhat.com>
Cc: David Hildenbrand <david@redhat.com>, qemu-s390x@nongnu.org, Christian Borntraeger <borntraeger@de.ibm.com>, qemu-devel@nongnu.org, Juan Quintela <quintela@redhat.com>

On 25.07.2018 15:48, Cornelia Huck wrote:
> On Wed, 25 Jul 2018 14:20:14 +0200
> Thomas Huth <thuth@redhat.com> wrote:
> 
>> For more fine-grained control over the build process, it would be good
>> to have the possibility to disable single virtio devices, too. We already
>> have CONFIG_VIRTIO_* switches in the Makefiles, but currently all
>> virtio-ccw devices are compiled in anyway. Move them to separate files
>> so we can disable them in the Makefile more easily.
>>
>> NB: I did not move virtio-blk-ccw and virtio-net-ccw to a separate file
>> yet since they are essential for the s390x-virtio machine and thus it
>> does IMHO not make much sense to disable net and blk. But if somebody
>> needs that possibility, too, I can add two more patches on top...
> 
> I understand virtio-net-ccw (autogenerated network devices), but why
> virtio-blk-ccw?

Because we set mc->block_default_type = IF_VIRTIO ==> if you disable
virtio-blk, the CLI options like -hda and -cdrom would not work anymore.

> Regardless, it might make sense to split them out so that we get a
> slimmed-down virtio-ccw.c.

OK.

 Thomas