From: Cole Robinson <crobinso@redhat.com>
To: deller@gmx.de
Cc: qemu-devel <qemu-devel@nongnu.org>,
"Richard W.M. Jones" <rjones@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: hppa-firmware.img missing build-id
Date: Tue, 23 Apr 2024 10:58:44 -0400 [thread overview]
Message-ID: <d0e87002-ee5e-4a80-b850-1660bc5f2c80@redhat.com> (raw)
In-Reply-To: <6c469c05-1bc5-4fd8-89f1-130f5aba5ff8@redhat.com>
On 4/23/24 10:11 AM, Cole Robinson wrote:
> Hi,
>
> hppa-firmware.img and hppa-firmware64.img in qemu.git are missing ELF
> build-id annotations. rpm builds on Fedora will error if an ELF binary
> doesn't have build-id:
>
> RPM build errors:
> Missing build-id in
> /tmp/rpmbuild/BUILDROOT/qemu-9.0.0-1.rc2.fc41.x86_64/usr/share/qemu/hppa-firmware.img
> Missing build-id in
> /tmp/rpmbuild/BUILDROOT/qemu-9.0.0-1.rc2.fc41.x86_64/usr/share/qemu/hppa-firmware64.img
> Generating build-id links failed
>
> I didn't hit this with qemu 8.2.* builds FWIW
>
Though checking older bundled hppa-firmware binaries with `readelf` I
don't see build-id either, so now I'm not sure why those RPM builds were
passing.
FWIW the RPM check is deep in RPM code:
https://github.com/rpm-software-management/rpm/blob/68d0f3119c3d46b6184f4704edb51749ce9f819e/build/files.c#L1976
Maybe something else in hppa-firmware ELF headers caused this check to
be skipped in the past
Thanks,
Cole
next prev parent reply other threads:[~2024-04-23 14:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 14:11 hppa-firmware.img missing build-id Cole Robinson
2024-04-23 14:58 ` Cole Robinson [this message]
2024-04-23 15:07 ` Helge Deller
2024-04-23 15:10 ` Daniel P. Berrangé
2024-04-23 18:50 ` Helge Deller
2024-04-23 15:02 ` Richard W.M. Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0e87002-ee5e-4a80-b850-1660bc5f2c80@redhat.com \
--to=crobinso@redhat.com \
--cc=deller@gmx.de \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=rjones@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).