From: Richard Henderson <richard.henderson@linaro.org>
To: Stefan Weil <sw@weilnetz.de>, Peter Maydell <peter.maydell@linaro.org>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Paul Durrant" <paul@xen.org>,
"QEMU Developers" <qemu-devel@nongnu.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Anthony Perard" <anthony.perard@citrix.com>,
"open list:X86" <xen-devel@lists.xenproject.org>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argument
Date: Tue, 18 Feb 2020 11:14:07 -0800 [thread overview]
Message-ID: <d0eab4fe-14ec-70a0-6917-8fc097265bf7@linaro.org> (raw)
In-Reply-To: <eed26f29-6cbd-7663-7f30-39596bb70422@weilnetz.de>
On 2/18/20 10:59 AM, Stefan Weil wrote:
> Personally I like the way how the standard C library handles such
> pointers for functions like memcpy, fread, fwrite and others.
>
> Therefore I suggest to use `const void *` and `void *` and to avoid type
> casts.
Seconded.
r~
next prev parent reply other threads:[~2020-02-18 19:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 13:20 [PATCH] Avoid cpu_physical_memory_rw() with a constant is_write argument Philippe Mathieu-Daudé
2020-02-18 17:39 ` Richard Henderson
2020-02-18 17:57 ` Stefan Weil
2020-02-18 18:13 ` Philippe Mathieu-Daudé
2020-02-18 18:49 ` Peter Maydell
2020-02-18 18:59 ` Stefan Weil
2020-02-18 19:00 ` Stefan Weil
2020-02-18 19:14 ` Richard Henderson [this message]
2020-02-18 20:07 ` Philippe Mathieu-Daudé
2020-02-18 21:16 ` Peter Maydell
2020-02-20 11:32 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0eab4fe-14ec-70a0-6917-8fc097265bf7@linaro.org \
--to=richard.henderson@linaro.org \
--cc=anthony.perard@citrix.com \
--cc=ehabkost@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=sstabellini@kernel.org \
--cc=sw@weilnetz.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).