From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB891C433ED for ; Wed, 31 Mar 2021 13:14:55 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CCFA361969 for ; Wed, 31 Mar 2021 13:14:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CCFA361969 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:60458 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lRagP-0004Pq-K0 for qemu-devel@archiver.kernel.org; Wed, 31 Mar 2021 09:14:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lRafL-0003uW-HE; Wed, 31 Mar 2021 09:13:47 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]:50824) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lRafK-0002qx-03; Wed, 31 Mar 2021 09:13:47 -0400 Received: by mail-wm1-x32a.google.com with SMTP id g25so10179292wmh.0; Wed, 31 Mar 2021 06:13:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2imILVcWDhiWtLMyZB9g3JpmaqOWwGDkSEShu4U5JT0=; b=TkVpzMEdBkT0lZ456GlW7Xkm4iVez3wlB4axs37OBJ6hg8IggasKV6/iYc2LQlxFA+ pAAGhP6Ga6/aNsU7poXMo/yIKgrOvCLn+IQ71dA6QX5BRY/fKK+MNoWaS+NnPEQd9817 U3yXEtpH+sze2/5Zfs+XxboWa1oFqp4DFrD59+xViXXT8EnkNj1PpUbbkTWWYJa55fIu BOjWgNeBR2RlZGJN+hgzgV+LmM2XCX6g4nBJ9XoZno1AkSqU/eVurk+UrKCdfiJUpNQo eaGF0UxQUS3zo/qw66Rld49CiMIKh0MVTPGIUh0gGAazKCzsuuTHd4B7xb7mVMbvC2gu j6Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2imILVcWDhiWtLMyZB9g3JpmaqOWwGDkSEShu4U5JT0=; b=fLwc8o03jQXBDy07NNVdf5c/EWV9+gOv+BY+Q4ej1c8/qrin3iRasXloxItOrj98tM DFvcWDY8H4dHcGmvk3sf5iAIc5S0aNZ7dN1QKz2xC8087eD6/qEejrOWH2a7yfAApKDW Bk3XEMXEvrw8egL3QEBrZDy5KF9PUNAsYXVIkvliGX2czQpNYPAAlII0qv3SOoQ6pBsG JiAqr8qsR8xXqYgRqDXcMzQPJS+ULVPAK/PXpb6mWBdlOZ6n1VJjlUFZbIXGZVnfOpIm g//jEVMN2YYnXuc3l9nwKQVva6Y8RmMcWYGb1uH0le0GbCQkMCozrp3sIrEqZilm2BN/ Vx3Q== X-Gm-Message-State: AOAM533x+ChcY3Wo2bXycWpNqpGgDSZnOMJycXxBR6COPtAL+wiEgdJM U0D1xCKdd7ZYu0acGFtuklQ= X-Google-Smtp-Source: ABdhPJzxbTjQO8IT0O2lwZq9fHL7mVaKa1tB8U2bZYT7dSSCOjIgOXvf0yAc199bKLSXczw1qZqukg== X-Received: by 2002:a7b:c186:: with SMTP id y6mr3238175wmi.84.1617196424086; Wed, 31 Mar 2021 06:13:44 -0700 (PDT) Received: from [192.168.1.36] (17.red-88-21-201.staticip.rima-tde.net. [88.21.201.17]) by smtp.gmail.com with ESMTPSA id u8sm4764708wrr.42.2021.03.31.06.13.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Mar 2021 06:13:43 -0700 (PDT) Subject: Re: [PATCH] hw/riscv: sifive_e: Add 'const' to sifive_e_memmap[] To: Bin Meng , Alistair Francis , qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20210331103612.654261-1-bmeng.cn@gmail.com> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: Date: Wed, 31 Mar 2021 15:13:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210331103612.654261-1-bmeng.cn@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wm1-x32a.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Emmanuel Blot Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/31/21 12:36 PM, Bin Meng wrote: > This was accidentally dropped before. Add it back. > Fixes: 732612856a8 ("hw/riscv: Drop 'struct MemmapEntry'") > Reported-by: Emmanuel Blot > Signed-off-by: Bin Meng Reviewed-by: Philippe Mathieu-Daudé > --- > > hw/riscv/sifive_e.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/riscv/sifive_e.c b/hw/riscv/sifive_e.c > index f939bcf9ea..82096b3e5a 100644 > --- a/hw/riscv/sifive_e.c > +++ b/hw/riscv/sifive_e.c > @@ -50,7 +50,7 @@ > #include "sysemu/sysemu.h" > #include "exec/address-spaces.h" > > -static MemMapEntry sifive_e_memmap[] = { > +static const MemMapEntry sifive_e_memmap[] = { > [SIFIVE_E_DEV_DEBUG] = { 0x0, 0x1000 }, > [SIFIVE_E_DEV_MROM] = { 0x1000, 0x2000 }, > [SIFIVE_E_DEV_OTP] = { 0x20000, 0x2000 }, >