From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56797) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fg3qj-0006SU-QA for qemu-devel@nongnu.org; Thu, 19 Jul 2018 03:59:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fg3qg-0004J5-5r for qemu-devel@nongnu.org; Thu, 19 Jul 2018 03:59:45 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:46790 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fg3qf-0004I1-MT for qemu-devel@nongnu.org; Thu, 19 Jul 2018 03:59:41 -0400 References: <8b9563c3-1e1d-4a34-8995-48e90aaea9fd@redhat.com> From: Thomas Huth Message-ID: Date: Thu, 19 Jul 2018 09:59:38 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 0/5] riscv: Fix introspection problems List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Alistair Francis , "qemu-devel@nongnu.org Developers" , Michael Clark , Markus Armbruster On 18.07.2018 23:31, Alistair Francis wrote: > On Wed, Jul 18, 2018 at 12:22 AM, Thomas Huth wrote: >> On 17.07.2018 22:27, Alistair Francis wrote: >>> This is based on Thomas's work fixing introspection problems [1] and >>> applied to the RISC-V port. >>> >>> 1: https://lists.gnu.org/archive/html/qemu-devel/2018-07/msg03261.html >>> >>> Alistair Francis (5): >>> sifive_e: Fix crash when introspecting the device >>> sifive_u: Fix crash when introspecting the device >>> virt: Fix crash when introspecting the device >>> riscv_hart: Fix crash when introspecting the device >>> spike: Fix crash when introspecting the device >>> >>> hw/riscv/riscv_hart.c | 7 +++---- >>> hw/riscv/sifive_e.c | 12 ++++++------ >>> hw/riscv/sifive_u.c | 15 +++++++-------- >>> hw/riscv/spike.c | 10 ++++------ >>> hw/riscv/virt.c | 5 ++--- >>> 5 files changed, 22 insertions(+), 27 deletions(-) >> >> That's interesting, these issues did not appear in my tests (modified >> tests/device-introspect-test.c with hmp("info qtree")). Likely because >> device-introspect-test only checks with the "none" machine ==> one more >> reason to test here with all machines, too (I suggested such a patch a >> couple of months ago) ... > > What happened to the patch? More tests would be super handy. It was only a RFC since at that point in time, there were lots of other crashes, so it could not be merged yet: http://lists.gnu.org/archive/html/qemu-devel/2018-03/msg05033.html I think the other crashes are now fixed, too, so we could consider this again. I'll put it on my TODO list to respin it for 3.1 ... Thomas