From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Cc: Markus Armbruster <armbru@redhat.com>,
Kevin Wolf <kwolf@redhat.com>,
vsementsov@virtuozzo.com, Juan Quintela <quintela@redhat.com>,
Max Reitz <mreitz@redhat.com>,
libvir-list@redhat.com,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>, Fam Zheng <fam@euphon.net>
Subject: Re: [Qemu-devel] [PATCH v3 05/10] nbd: change error checking order for bitmaps
Date: Sat, 23 Feb 2019 15:29:33 -0600 [thread overview]
Message-ID: <d1213529-58d2-0a12-febb-a8a2f7cce3ce@redhat.com> (raw)
In-Reply-To: <20190223000614.13894-6-jsnow@redhat.com>
On 2/22/19 6:06 PM, John Snow wrote:
> Check that the bitmap is not in use prior to it checking if it is
> not enabled/recording guest writes. The bitmap being busy was likely
> at the behest of the user, so this error has a greater chance of being
> understood by the user.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> nbd/server.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2019-02-23 21:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-23 0:06 [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field John Snow
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 01/10] block/dirty-bitmap: add recording and busy properties John Snow
2019-02-23 20:06 ` Eric Blake
2019-02-25 6:23 ` Vladimir Sementsov-Ogievskiy
2019-02-25 15:01 ` Vladimir Sementsov-Ogievskiy
2019-02-25 15:08 ` Eric Blake
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 02/10] block/dirty-bitmaps: rename frozen predicate helper John Snow
2019-02-23 21:10 ` Eric Blake
2019-02-25 7:01 ` Vladimir Sementsov-Ogievskiy
2019-02-25 20:09 ` John Snow
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 03/10] block/dirty-bitmap: remove set/reset assertions against enabled bit John Snow
2019-02-23 21:11 ` Eric Blake
2019-02-25 7:09 ` Vladimir Sementsov-Ogievskiy
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 04/10] block/dirty-bitmap: change semantics of enabled predicate John Snow
2019-02-23 21:14 ` Eric Blake
2019-02-25 7:39 ` Vladimir Sementsov-Ogievskiy
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 05/10] nbd: change error checking order for bitmaps John Snow
2019-02-23 21:29 ` Eric Blake [this message]
2019-02-25 7:44 ` Vladimir Sementsov-Ogievskiy
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 06/10] block/dirty-bitmap: explicitly lock bitmaps with successors John Snow
2019-02-25 7:48 ` Vladimir Sementsov-Ogievskiy
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 07/10] block/dirty-bitmaps: unify qmp_locked and user_locked calls John Snow
2019-02-23 21:32 ` Eric Blake
2019-02-25 12:03 ` Vladimir Sementsov-Ogievskiy
2019-02-25 20:37 ` John Snow
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 08/10] block/dirty-bitmaps: move comment block John Snow
2019-02-23 21:32 ` Eric Blake
2019-02-25 12:11 ` Vladimir Sementsov-Ogievskiy
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 09/10] blockdev: remove unused paio parameter documentation John Snow
2019-02-23 21:33 ` Eric Blake
2019-02-25 12:20 ` Vladimir Sementsov-Ogievskiy
2019-02-23 0:06 ` [Qemu-devel] [PATCH v3 10/10] iotests: add busy/recording bit test to 124 John Snow
2019-02-23 22:06 ` Eric Blake
2019-02-25 20:29 ` John Snow
2019-02-25 22:08 ` [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field John Snow
2019-02-27 17:45 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1213529-58d2-0a12-febb-a8a2f7cce3ce@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=fam@euphon.net \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).