From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:49807) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxerz-0007pZ-2E for qemu-devel@nongnu.org; Sat, 23 Feb 2019 16:30:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxerw-0005BU-H9 for qemu-devel@nongnu.org; Sat, 23 Feb 2019 16:30:02 -0500 References: <20190223000614.13894-1-jsnow@redhat.com> <20190223000614.13894-6-jsnow@redhat.com> From: Eric Blake Message-ID: Date: Sat, 23 Feb 2019 15:29:33 -0600 MIME-Version: 1.0 In-Reply-To: <20190223000614.13894-6-jsnow@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 05/10] nbd: change error checking order for bitmaps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org, qemu-block@nongnu.org Cc: Markus Armbruster , Kevin Wolf , vsementsov@virtuozzo.com, Juan Quintela , Max Reitz , libvir-list@redhat.com, "Dr. David Alan Gilbert" , Stefan Hajnoczi , Fam Zheng On 2/22/19 6:06 PM, John Snow wrote: > Check that the bitmap is not in use prior to it checking if it is > not enabled/recording guest writes. The bitmap being busy was likely > at the behest of the user, so this error has a greater chance of being > understood by the user. > > Signed-off-by: John Snow > --- > nbd/server.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org