From: Thomas Huth <thuth@redhat.com>
To: Konstantin Kostiuk <kkostiuk@redhat.com>, qemu-devel@nongnu.org
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Michael Roth" <michael.roth@amd.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: [PATCH v5 1/4] QGA VSS: Add wrapper to send log to debugger and stderr
Date: Mon, 10 Jul 2023 11:33:55 +0200 [thread overview]
Message-ID: <d124fc1f-569c-f2ec-f515-7e4ad921884f@redhat.com> (raw)
In-Reply-To: <20230710091439.1010553-2-kkostiuk@redhat.com>
On 10/07/2023 11.14, Konstantin Kostiuk wrote:
> Signed-off-by: Konstantin Kostiuk <kkostiuk@redhat.com>
> ---
> qga/vss-win32/meson.build | 2 +-
> qga/vss-win32/vss-debug.cpp | 39 +++++++++++++++++++++++++++++++++++++
> qga/vss-win32/vss-debug.h | 25 ++++++++++++++++++++++++
> 3 files changed, 65 insertions(+), 1 deletion(-)
> create mode 100644 qga/vss-win32/vss-debug.cpp
> create mode 100644 qga/vss-win32/vss-debug.h
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2023-07-10 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-10 9:14 [PATCH v5 0/4] QGA VSS Logging Konstantin Kostiuk
2023-07-10 9:14 ` [PATCH v5 1/4] QGA VSS: Add wrapper to send log to debugger and stderr Konstantin Kostiuk
2023-07-10 9:33 ` Thomas Huth [this message]
2023-07-10 9:14 ` [PATCH v5 2/4] QGA VSS: Replace 'fprintf(stderr' with qga_debug Konstantin Kostiuk
2023-07-10 9:34 ` Thomas Huth
2023-07-10 9:14 ` [PATCH v5 3/4] QGA VSS: Print error in err_set Konstantin Kostiuk
2023-07-10 9:14 ` [PATCH v5 4/4] QGA VSS: Add log in functions begin/end Konstantin Kostiuk
2023-07-10 10:38 ` Konstantin Kostiuk
2023-07-10 10:56 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d124fc1f-569c-f2ec-f515-7e4ad921884f@redhat.com \
--to=thuth@redhat.com \
--cc=kkostiuk@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).