From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Luc Michel <luc.michel@amd.com>
Cc: "Marc-André Lureau" <marcandre.lureau@redhat.com>,
qemu-devel@nongnu.org,
"Evgeny Iakovlev" <eiakovlev@linux.microsoft.com>,
"Rayhan Faizel" <rayhan.faizel@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
"Magnus Damm" <magnus.damm@gmail.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Thomas Huth" <huth@tuxfamily.org>,
"Shin'ichiro Kawasaki" <shinichiro.kawasaki@wdc.com>,
qemu-arm@nongnu.org
Subject: Re: [PATCH 5/9] hw/char/bcm2835_aux: Really use RX FIFO depth
Date: Thu, 20 Feb 2025 09:28:40 +0100 [thread overview]
Message-ID: <d159a860-21b2-46e8-a74f-cd6be14ea525@linaro.org> (raw)
In-Reply-To: <Z7bmAqE4z2y_kNse@XFR-LUMICHEL-L2.amd.com>
On 20/2/25 09:21, Luc Michel wrote:
> On 22:08 Wed 19 Feb , Philippe Mathieu-Daudé wrote:
>> While we model a 8-elements RX FIFO since the PL011 model was
>> introduced in commit 97398d900ca ("bcm2835_aux: add emulation
>> of BCM2835 AUX block") we only read 1 char at a time!
>
> I'm not sure I get why in this patch and the subsequent ones you keep
> mentioning the PL011 model while you modify other UARTs. I guess you
> mean "the BCM2835 AUX model" here?
Oops too much copy/pasting...
>
> In any case:
>
> Reviewed-by: Luc Michel <luc.michel@amd.com>
Thanks!
>
>>
>> Have the IOCanReadHandler handler return how many elements are
>> available, and use that in the IOReadHandler handler.
>>
>> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
>> ---
>> hw/char/bcm2835_aux.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
next prev parent reply other threads:[~2025-02-20 8:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 21:08 [PATCH 0/9] hw/char: Improve RX FIFO depth uses Philippe Mathieu-Daudé
2025-02-19 21:08 ` [PATCH 1/9] hw/char/pl011: Warn when using disabled receiver Philippe Mathieu-Daudé
2025-02-20 8:11 ` Luc Michel
2025-02-19 21:08 ` [PATCH 2/9] hw/char/pl011: Simplify a bit pl011_can_receive() Philippe Mathieu-Daudé
2025-02-20 8:12 ` Luc Michel
2025-02-19 21:08 ` [PATCH 3/9] hw/char/pl011: Improve RX flow tracing events Philippe Mathieu-Daudé
2025-02-19 22:09 ` Alex Bennée
2025-02-20 8:14 ` Luc Michel
2025-02-19 21:08 ` [PATCH 4/9] hw/char/pl011: Really use RX FIFO depth Philippe Mathieu-Daudé
2025-02-20 8:17 ` Luc Michel
2025-02-19 21:08 ` [PATCH 5/9] hw/char/bcm2835_aux: " Philippe Mathieu-Daudé
2025-02-20 8:21 ` Luc Michel
2025-02-20 8:28 ` Philippe Mathieu-Daudé [this message]
2025-02-19 21:08 ` [PATCH 6/9] hw/char/imx_serial: " Philippe Mathieu-Daudé
2025-02-20 8:22 ` Luc Michel
2025-02-19 21:08 ` [PATCH 7/9] hw/char/mcf_uart: Use FIFO_DEPTH definition instead of magic values Philippe Mathieu-Daudé
2025-02-20 8:24 ` Luc Michel
2025-02-19 21:08 ` [PATCH 8/9] hw/char/mcf_uart: Really use RX FIFO depth Philippe Mathieu-Daudé
2025-02-20 8:26 ` Luc Michel
2025-02-19 21:08 ` [PATCH 9/9] hw/char/sh_serial: Return correct number of empty RX FIFO elements Philippe Mathieu-Daudé
2025-02-20 8:30 ` Luc Michel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d159a860-21b2-46e8-a74f-cd6be14ea525@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=eiakovlev@linux.microsoft.com \
--cc=huth@tuxfamily.org \
--cc=luc.michel@amd.com \
--cc=magnus.damm@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rayhan.faizel@gmail.com \
--cc=shinichiro.kawasaki@wdc.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).